You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (Created) (JIRA)" <ji...@apache.org> on 2012/02/10 19:45:00 UTC
[jira] [Created] (HBASE-5382) Test that we always cache index and
bloom blocks
Test that we always cache index and bloom blocks
------------------------------------------------
Key: HBASE-5382
URL: https://issues.apache.org/jira/browse/HBASE-5382
Project: HBase
Issue Type: Test
Reporter: Mikhail Bautin
This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Mikhail Bautin (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205727#comment-13205727 ]
Mikhail Bautin commented on HBASE-5382:
---------------------------------------
@Ted: I ran unit tests and the patch passed all of them (not just small and medium that Hadoop QA runs). I got a +1 on this from JD, and this code has been previously reviewed and approved as part of HBASE-4683. Sorry if this is a misunderstanding, but I thought we had plans of increasing the memory limit of HBase QA?
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5382:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed a few days back
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205766#comment-13205766 ]
Hudson commented on HBASE-5382:
-------------------------------
Integrated in HBase-TRUNK #2658 (See [https://builds.apache.org/job/HBase-TRUNK/2658/])
[jira] [HBASE-5382] Test that we always cache index and bloom blocks
Summary: This is a unit test that should have been part of HBASE-4683 but was
not committed. The original test was reviewed as part of
https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and
patch, and extending the scope of the test to also handle the case when block
cache is enabled for the column family.
Test Plan: Run unit tests
Reviewers: JIRA, jdcryans, lhofhansl, Liyin
Reviewed By: jdcryans
CC: jdcryans
Differential Revision: https://reviews.facebook.net/D1695
mbautin :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HBASE-5382:
----------------------------------
Description: This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695. (was: This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.)
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205720#comment-13205720 ]
Zhihong Yu commented on HBASE-5382:
-----------------------------------
Looks like the patch has been checked in:
{code}
1 out of 1 hunk ignored -- saving rejects to file src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java.rej
The next patch would create the file src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java,
which already exists! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java.rej
{code}
I suggest reverting the patch until Hadoop QA can reliably show that TestForceCacheImportantBlocks passes.
We already have two consistently failing tests. We don't want to make them three.
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205698#comment-13205698 ]
Hadoop QA commented on HBASE-5382:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12514142/TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 7 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -136 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 156 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/941//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/941//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/941//console
This message is automatically generated.
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206035#comment-13206035 ]
Hudson commented on HBASE-5382:
-------------------------------
Integrated in HBase-TRUNK-security #108 (See [https://builds.apache.org/job/HBase-TRUNK-security/108/])
[jira] [HBASE-5382] Test that we always cache index and bloom blocks
Summary: This is a unit test that should have been part of HBASE-4683 but was
not committed. The original test was reviewed as part of
https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and
patch, and extending the scope of the test to also handle the case when block
cache is enabled for the column family.
Test Plan: Run unit tests
Reviewers: JIRA, jdcryans, lhofhansl, Liyin
Reviewed By: jdcryans
CC: jdcryans
Differential Revision: https://reviews.facebook.net/D1695
mbautin :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205735#comment-13205735 ]
Zhihong Yu commented on HBASE-5382:
-----------------------------------
J-D's +1 came 44 minutes before Hadoop QA report.
I assume every +1 is contingent upon Hadoop QA's nod.
I think after reverting the patch, you can submit a new patch to Hadoop QA with increased heap.
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13210003#comment-13210003 ]
Phabricator commented on HBASE-5382:
------------------------------------
mbautin has committed the revision "[jira] [HBASE-5382] [89-fb] Test that we always cache index and bloom blocks".
REVISION DETAIL
https://reviews.facebook.net/D1773
COMMIT
https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1245298
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D1773.1.patch, TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205713#comment-13205713 ]
Zhihong Yu commented on HBASE-5382:
-----------------------------------
I think the test failure reported here:
https://builds.apache.org/job/PreCommit-HBASE-Build/941//testReport/org.apache.hadoop.hbase.io.hfile/TestForceCacheImportantBlocks/testCacheBlocks_2_/
is in line with the failed TestHFileBlock tests we have been seeing on Apache Jenkins for the past two weeks.
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HBASE-5382:
----------------------------------
Assignee: Mikhail Bautin
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Jean-Daniel Cryans (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205652#comment-13205652 ]
Jean-Daniel Cryans commented on HBASE-5382:
-------------------------------------------
+1
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HBASE-5382:
----------------------------------
Status: Patch Available (was: Open)
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209997#comment-13209997 ]
Phabricator commented on HBASE-5382:
------------------------------------
Liyin has accepted the revision "[jira] [HBASE-5382] [89-fb] Test that we always cache index and bloom blocks".
This patch is the exact same accepted patch based on apache trunk.
Thanks Mikhail !
REVISION DETAIL
https://reviews.facebook.net/D1773
BRANCH
tfcib
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D1773.1.patch, TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5382:
-------------------------------
Attachment: D1773.1.patch
mbautin requested code review of "[jira] [HBASE-5382] [89-fb] Test that we always cache index and bloom blocks".
Reviewers: JIRA, Liyin, jdcryans, lhofhansl
This is the 89-fb version of https://reviews.facebook.net/D1695, nearly identical to the original.
This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family.
TEST PLAN
Run unit tests
REVISION DETAIL
https://reviews.facebook.net/D1773
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3783/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D1773.1.patch, TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209162#comment-13209162 ]
Phabricator commented on HBASE-5382:
------------------------------------
mbautin has committed the revision "[jira] [HBASE-5382] Test that we always cache index and bloom blocks".
REVISION DETAIL
https://reviews.facebook.net/D1695
COMMIT
https://reviews.facebook.net/rHBASE1242894
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed as part of https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5382) Test that we always cache index and
bloom blocks
Posted by "Mikhail Bautin (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mikhail Bautin updated HBASE-5382:
----------------------------------
Attachment: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
> Test that we always cache index and bloom blocks
> ------------------------------------------------
>
> Key: HBASE-5382
> URL: https://issues.apache.org/jira/browse/HBASE-5382
> Project: HBase
> Issue Type: Test
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: TestForceCacheImportantBlocks-2012-02-10_11_07_15.patch
>
>
> This is a unit test that should have been part of HBASE-4683 but was not committed. The original test was reviewed https://reviews.facebook.net/D807. Submitting unit test as a separate JIRA and patch, and extending the scope of the test to also handle the case when block cache is enabled for the column family. The new review is at https://reviews.facebook.net/D1695.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira