You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/23 15:10:59 UTC

[GitHub] [flink] twalthr edited a comment on issue #9203: [FLINK-13375][table-api] Move ExecutionConfigOptions and OptimizerConfigOptions to table-api

twalthr edited a comment on issue #9203: [FLINK-13375][table-api] Move ExecutionConfigOptions and OptimizerConfigOptions to table-api
URL: https://github.com/apache/flink/pull/9203#issuecomment-514252939
 
 
   I think if we add a hierarchy in advance then it should be aligned by operator and not by functionality. 
   
   For example, instead of `table.optimizer.join-reorder.enabled` how about `table.optimizer.join.reorder-enabled`? Such that all join related config is grouped. Or instead of `table.optimizer.predicate-pushdown-enabled` how about `table.optimizer.source.predicate-pushdown-enabled`? 
   
   We should definitely avoid having more then 4 levels because it becomes hard to read.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services