You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/13 00:05:11 UTC
Review Request 13508: Fixed master to properly reconcile completed
frameworks when slave re-registers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13508/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-633
https://issues.apache.org/jira/browse/MESOS-633
Repository: mesos-git
Description
-------
This handles the case when the ShutdownFramework message isn't received by the slave (e.g., disconnected, partitioned).
Diffs
-----
src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df
src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8
Diff: https://reviews.apache.org/r/13508/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13508: Fixed master to properly reconcile completed
frameworks when slave re-registers.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 13, 2013, 6:32 p.m., Ben Mahler wrote:
> > src/tests/slave_recovery_tests.cpp, line 1645
> > <https://reviews.apache.org/r/13508/diff/1/?file=340253#file340253line1645>
> >
> > EXPECT_FALSE(offers.get().empty()); ?
For consistency with all the other tests, I will leave it as is.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13508/#review25083
-----------------------------------------------------------
On Aug. 12, 2013, 10:05 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13508/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 10:05 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-633
> https://issues.apache.org/jira/browse/MESOS-633
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This handles the case when the ShutdownFramework message isn't received by the slave (e.g., disconnected, partitioned).
>
>
> Diffs
> -----
>
> src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df
> src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8
>
> Diff: https://reviews.apache.org/r/13508/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13508: Fixed master to properly reconcile completed
frameworks when slave re-registers.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13508/#review25083
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/13508/#comment49271>
Can you make this a TODO given it's a short term hack?
What is the long term solution? Can you add that to the comment, or add a mention that we need to revisit this once we have... the registrar?
src/master/master.cpp
<https://reviews.apache.org/r/13508/#comment49272>
Can you add a using std::tr1::shared_ptr at the top of master.cpp and then declare this on one line:
>>> len(' foreach (const std::tr1::shared_ptr<Framework>& framework, completedFrameworks) {')
83
>>> len(' foreach (const shared_ptr<Framework>& framework, completedFrameworks) {')
73
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13508/#comment49263>
2 spaces
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13508/#comment49266>
EXPECT_FALSE(offers.get().empty()); ?
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13508/#comment49267>
Can you move this down to before the launchTasks call where 'tasks' is used?
- Ben Mahler
On Aug. 12, 2013, 10:05 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13508/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 10:05 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-633
> https://issues.apache.org/jira/browse/MESOS-633
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This handles the case when the ShutdownFramework message isn't received by the slave (e.g., disconnected, partitioned).
>
>
> Diffs
> -----
>
> src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df
> src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8
>
> Diff: https://reviews.apache.org/r/13508/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13508: Fixed master to properly reconcile completed
frameworks when slave re-registers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13508/
-----------------------------------------------------------
(Updated Aug. 13, 2013, 10:49 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. nnfr.
Bugs: MESOS-633
https://issues.apache.org/jira/browse/MESOS-633
Repository: mesos-git
Description
-------
This handles the case when the ShutdownFramework message isn't received by the slave (e.g., disconnected, partitioned).
Diffs (updated)
-----
src/master/master.cpp b6d12a3a1ef0785800cadbdbd7141dd79190d3df
src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8
Diff: https://reviews.apache.org/r/13508/diff/
Testing
-------
make check
Thanks,
Vinod Kone