[GitHub] [incubator-weex] weex-bot removed a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …

[GitBox <gi...@apache.org>]

weex-bot removed a comment on issue #2826: [Android] record ipc exception history and weexCoreThread stackTrace …
URL: https://github.com/apache/incubator-weex/pull/2826#issuecomment-521158796
 
 
   
   <!--
     2 failure:  AndroidLint Result, <section class="s...
     0 warning: 
     
     
     DangerID: danger-id-androidlint;
   -->
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Fails</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:no_entry_sign:</td>
         <td>AndroidLint Result</td>
       </tr>
     
   <tr>
         <td>:no_entry_sign:</td>
         <td>
   
     <section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="DefaultLocaleCard" style="display: block;">
               <div class="mdl-card mdl-cell mdl-cell--12-col">
     <div class="mdl-card__title">
       <h2 class="mdl-card__title-text">Implied default locale in case conversion</h2>
     </div>
                 <div class="mdl-card__supporting-text">
   <div class="issue">
   <div class="warningslist">
   <span class="location"><a href="../../src/main/java/com/taobao/weex/bridge/WXBridgeManager.java">../../src/main/java/com/taobao/weex/bridge/WXBridgeManager.java</a>:3614</span>: <span class="message">Implicitly using the default locale is a common source of bugs: Use <code>String.format(Locale, ...)</code> instead</span><br /><pre class="errorlines">
   <span class="lineno"> 3611 </span>
   <span class="lineno"> 3612 </span>  <span class="keyword">try</span> {
   <span class="lineno"> 3613 </span>    stringBuilder.append(String.format(<span class="string">"Thread Name: '%s'\n"</span>, mJSThread.getName()));
   <span class="caretline"><span class="lineno"> 3614 </span>    stringBuilder.append(<span class="warning">String.format(<span class="string">"\"%s\" prio=%d tid=%d %s\n"</span>, mJSThread.getName(), mJSThread.getPriority(), mJSThread.getId(), mJSThread.getState())</span>);</span>
   <span class="lineno"> 3615 </span>
   <span class="lineno"> 3616 </span>    <span class="keyword">for</span> (StackTraceElement e: mJSThread.getStackTrace()){
   <span class="lineno"> 3617 </span>      stringBuilder.append(String.format(<span class="string">"\tat %s\n"</span>, e.toString()));
   </pre>
   
   </div>
   <div class="metadata"><div class="explanation" id="explanationDefaultLocale" style="display: none;">
   Calling <code>String#toLowerCase()</code> or <code>#toUpperCase()</code> <b>without specifying an explicit locale</b> is a common source of bugs. The reason for that is that those methods will use the current locale on the user's device, and even though the code appears to work correctly when you are developing the app, it will fail in some locales. For example, in the Turkish locale, the uppercase replacement for <code>i</code> is <b>not</b> <code>I</code>.<br/>
   <br/>
   If you want the methods to just perform ASCII replacement, for example to convert an enum name, call <code>String#toUpperCase(Locale.US)</code> instead. If you really want to use the current locale, call <code>String#toUpperCase(Locale.getDefault())</code> instead.<br/><div class="moreinfo">More info: <a href="http://developer.android.com/reference/java/util/Locale.html#default_locale">http://developer.android.com/reference/java/util/Locale.html#default_locale</a>
   </div>To suppress this error, use the issue id "DefaultLocale" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/>
   <br/></div>
   </div>
   </div>
   <div class="chips">
   <span class="mdl-chip">
       <span class="mdl-chip__text">DefaultLocale</span>
   </span>
   <span class="mdl-chip">
       <span class="mdl-chip__text">Correctness</span>
   </span>
   <span class="mdl-chip">
       <span class="mdl-chip__text">Warning</span>
   </span>
   <span class="mdl-chip">
       <span class="mdl-chip__text">Priority 6/10</span>
   </span>
   </div>
                 </div>
                 <div class="mdl-card__actions mdl-card--border">
   <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationDefaultLocaleLink" onclick="reveal('explanationDefaultLocale');">
   Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="DefaultLocaleCardLink" onclick="hideid('DefaultLocaleCard');">
   Dismiss</button>            </div>
               </div>
             
     </td>
       </tr>
     </tbody>
   </table>
   
   
   
   
   <p align="right">
     Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against d0ca1e2b52e96da01ff1c02fd9ab489bea7e460b
   </p>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services