[jira] [Commented] (HADOOP-8140) dfs -getmerge should process its argments better

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222572#comment-13222572 ] 

Hadoop QA commented on HADOOP-8140:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12517110/HADOOP-8140.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.fs.viewfs.TestViewFsTrash
                  org.apache.hadoop.fs.TestFsShellCopy

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/671//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/671//console

This message is automatically generated.
                
> dfs -getmerge  should process its argments better 
> --------------------------------------------------
>
>                 Key: HADOOP-8140
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8140
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: arkady borkovsky
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-8140.patch, Hadoop-1004_1.patch
>
>
> The command only works if its argument is a directory
> If the argement is a file or a wildcard, it does nothing without any message.
> If not arguments are given, the command fails with a stack dump.
> The improved version should:
> -- produce an error message in case it cannot perform meaningful action (no argument, or no matching files)
> -- copy the files specified by a wildcard expresstion.  (A single file is special case of this).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira