[GitHub] [spark] MaxGekk commented on a change in pull request #27707: [SPARK-30958][SQL] do not set default era for DateTimeFormatter

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #27707: [SPARK-30958][SQL] do not set default era for DateTimeFormatter
URL: https://github.com/apache/spark/pull/27707#discussion_r384607430
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
 ##########
 @@ -82,7 +81,14 @@ private object DateTimeFormatterHelper {
 
   def buildFormatter(pattern: String, locale: Locale): DateTimeFormatter = {
     val builder = createBuilder().appendPattern(pattern)
-    toFormatter(builder, locale)
+    if (pattern.contains("y")) {
 
 Review comment:
   Another ways is to get access to the following list in `DateTimeFormatterBuilder`:
   ```java
   private final List<DateTimePrinterParser> printerParsers = new ArrayList<>();
   ```
   via reflection, and find `NumberPrinterParser` with `field` == `ChronoField.YEAR_OF_ERA`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org