You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/25 12:35:55 UTC

[GitHub] [pulsar-client-go] wuYin opened a new pull request #449: Fix logrusWrapper shrink interfaces slice into an interface

wuYin opened a new pull request #449:
URL: https://github.com/apache/pulsar-client-go/pull/449


   ### Issue
   logrusWrapper formater shrink  `[]interface{}` args into a `interface{}`, causes logrus formatter missing arguments.
   
   format case
   ```
   ls.log.Debugf("Successfully looked up topic{%s} on broker. %s / %s - Use proxy: %t",
                  topic, lr.GetBrokerServiceUrl(), lr.GetBrokerServiceUrlTls(), lr.GetProxyThroughServiceUrl())
   ```
   logging looks like:
   ```
   DEBU[0000] Successfully looked up topic{[persistent://public/default/topic-1 pulsar://localhost:6651  %!s(bool=false)]} on broker. %!s(MISSING) / %!s(MISSING) - Use proxy: %!t(MISSING)  serviceURL="pulsar://localhost:6650"
   ```
   
   ### Motivation
   
   Fix logrus formatter missing arguments.
   
   
   ### Modifications
   
   Expand `[]interface{}` before invoke logrus logger, pass them to logrus intact.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] merlimat merged pull request #449: Fix logrusWrapper shrink interfaces slice into an interface

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #449:
URL: https://github.com/apache/pulsar-client-go/pull/449


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] merlimat merged pull request #449: Fix logrusWrapper shrink interfaces slice into an interface

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #449:
URL: https://github.com/apache/pulsar-client-go/pull/449


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #449: Fix logrusWrapper shrink interfaces slice into an interface

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #449:
URL: https://github.com/apache/pulsar-client-go/pull/449#issuecomment-766838777


   ping @merlimat PTAL thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-go] wolfstudy commented on pull request #449: Fix logrusWrapper shrink interfaces slice into an interface

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on pull request #449:
URL: https://github.com/apache/pulsar-client-go/pull/449#issuecomment-766838777


   ping @merlimat PTAL thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org