[GitHub] [kyuubi] cxzl25 commented on pull request #4688: Fix the failure to read the operation log after executing catalog and database operation

["cxzl25 (via GitHub)" <gi...@apache.org>]

cxzl25 commented on PR #4688:
URL: https://github.com/apache/kyuubi/pull/4688#issuecomment-1502626631

   > Why do we create operation logs for these lightweight operations?
   
   Because `OperationManager#getOperationLogRowSet` will check whether the operation log has a value, or allow `operationLog` to be none here instead of throwing an exception.
   
   https://github.com/apache/kyuubi/blob/f0615a9aab0a5b755c16ee0b966a5ea59b98bd10/kyuubi-common/src/main/scala/org/apache/kyuubi/operation/OperationManager.scala#L144-L152
   
   
   > Or why do we fetch logs from the client side?
   
   Because these operations are executed using `KyuubiStatement`, `isLogBeingGenerated` is true by default and will try to fetch query log, which is the default behavior of client.
   
   https://github.com/apache/kyuubi/blob/f0615a9aab0a5b755c16ee0b966a5ea59b98bd10/kyuubi-hive-jdbc/src/main/java/org/apache/kyuubi/jdbc/hive/KyuubiStatement.java#L649-L660
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org