[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #18690: [WIP] optimize graph in presence of dynamic shape ops

[GitBox <gi...@apache.org>]

mseth10 commented on a change in pull request #18690:
URL: https://github.com/apache/incubator-mxnet/pull/18690#discussion_r464748849



##########
File path: python/mxnet/symbol/symbol.py
##########
@@ -2665,11 +2665,30 @@ def _optimize_for_dynamic_shape_op(self, is_np_array):
             - If true, output type is np symbol, otherwise nd symbol.
         """
         out = SymbolHandle()
-        check_call(_LIB.MXOptimizeForDynamicShapeOp(self.handle, ctypes.byref(out)))
+        has_dynamic_shape = ctypes.c_bool(False)
+
+        # Pass static_allco and static_shape flags into c_api
+        key_list = []
+        val_list = []
+        for flag in flags:
+            key, val = flag[0], flag[1]
+            if key == ['static_alloc', 'static_shape']:

Review comment:
       shouldnt it be `if key in ['static_alloc', 'static_shape']:`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org