You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/19 10:06:38 UTC
[GitHub] [maven-gh-actions-shared] olamy opened a new pull request, #55: add a clean to ensure we do not lock files for a windows build
olamy opened a new pull request, #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55
cherry-pick of https://github.com/apache/maven-gh-actions-shared/commit/6fb412f2817e5c91dd530405f4568204e4fbea6e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #55: add a clean to ensure we do not lock files for a windows build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55#discussion_r924329422
##########
.github/workflows/maven-verify.yml:
##########
@@ -182,13 +182,10 @@ jobs:
run:
mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.1.0:wrapper "-Dmaven=${{ inputs.ff-maven }}"
- - name: Build with Maven
- run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-goal }}
-
Review Comment:
should be not removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #55: add a clean to ensure we do not lock files for a windows build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55#discussion_r924320960
##########
.github/workflows/maven-verify.yml:
##########
@@ -184,10 +184,17 @@ jobs:
- name: Build with Maven
run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-goal }}
+
+ - name: Clean Ensuring no file handle remains open on windows
+ run: ./mvnw clean --errors --batch-mode --show-version
- name: Build Maven Site
run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-site-goal }}
if: inputs.ff-site-run
+
+ - name: Clean Ensuring no file handle remains open on windows
+ if: steps.should-run.conclusion == 'success'
+ run: ./mvnw clean --errors --batch-mode --show-version
Review Comment:
put it after `Show free disk space` we need files for `Upload Maven Site` and for `Upload artifact on failure`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #55: add a clean to ensure we do not lock files for a windows build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55#discussion_r924322483
##########
.github/workflows/maven-verify.yml:
##########
@@ -184,10 +184,17 @@ jobs:
- name: Build with Maven
run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-goal }}
+
+ - name: Clean Ensuring no file handle remains open on windows
+ run: ./mvnw clean --errors --batch-mode --show-version
Review Comment:
We have two `clean` in `fail-fast-build` - one should be in `verify` jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #55: add a clean to ensure we do not lock files for a windows build
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55#discussion_r924337037
##########
.github/workflows/maven-verify.yml:
##########
@@ -182,13 +182,10 @@ jobs:
run:
mvn --errors --batch-mode --show-version org.apache.maven.plugins:maven-wrapper-plugin:3.1.0:wrapper "-Dmaven=${{ inputs.ff-maven }}"
- - name: Build with Maven
- run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-goal }}
-
Review Comment:
sorry grrhhh %#%@%^#@*^%# gh web editor (pardon my french)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #55: add a clean to ensure we do not lock files for a windows build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55#discussion_r924329027
##########
.github/workflows/maven-verify.yml:
##########
@@ -207,6 +204,10 @@ jobs:
if: always()
run: df -h
shell: bash
+
+ - name: Clean Ensuring no file handle remains open on windows
+ if: steps.should-run.conclusion == 'success'
Review Comment:
step `should-run` only exist in `verify` jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] slawekjaranowski commented on a diff in pull request #55: add a clean to ensure we do not lock files for a windows build
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55#discussion_r924363546
##########
.github/workflows/maven-verify.yml:
##########
@@ -188,7 +188,7 @@ jobs:
- name: Build Maven Site
run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-site-goal }}
if: inputs.ff-site-run
-
+
Review Comment:
additional whitespace - not important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] olamy commented on a diff in pull request #55: add a clean to ensure we do not lock files for a windows build
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55#discussion_r924326645
##########
.github/workflows/maven-verify.yml:
##########
@@ -184,10 +184,17 @@ jobs:
- name: Build with Maven
run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-goal }}
+
+ - name: Clean Ensuring no file handle remains open on windows
+ run: ./mvnw clean --errors --batch-mode --show-version
- name: Build Maven Site
run: ./mvnw --errors --batch-mode --show-version ${{ inputs.maven-args }} ${{ inputs.ff-site-goal }}
if: inputs.ff-site-run
+
+ - name: Clean Ensuring no file handle remains open on windows
+ if: steps.should-run.conclusion == 'success'
+ run: ./mvnw clean --errors --batch-mode --show-version
Review Comment:
yup we don't know if the basic build or the site build is locking.
but that would be nit picking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-gh-actions-shared] olamy merged pull request #55: add a clean to ensure we do not lock files for a windows build
Posted by GitBox <gi...@apache.org>.
olamy merged PR #55:
URL: https://github.com/apache/maven-gh-actions-shared/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org