You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2020/08/27 16:35:35 UTC
[GitHub] [httpcomponents-core] carterkozak opened a new pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
carterkozak opened a new pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220#issuecomment-682141295
Absolutely, I've addressed this in #221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o removed a comment on pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
Posted by GitBox <gi...@apache.org>.
michael-o removed a comment on pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220#issuecomment-682093237
Hod die you find this and would the but look like?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220#issuecomment-682110368
I'll add an hpack test that fails without reading array offset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220#issuecomment-682093711
How did you find this and how would it change behavior?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] michael-o commented on pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220#issuecomment-682093237
Hod die you find this and would the but look like?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] bindul commented on pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
Posted by GitBox <gi...@apache.org>.
bindul commented on pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220#issuecomment-682140761
I wonder if the `arrayOffset` calls should be conditional based on `hasArray`. Based on the Javadoc [1] This is an optional operation and hence can throw `UnsupportedOperationException`.
[1] https://docs.oracle.com/javase/8/docs/api/java/nio/ByteBuffer.html#arrayOffset--
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak commented on pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
Posted by GitBox <gi...@apache.org>.
carterkozak commented on pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220#issuecomment-682097219
I noticed [this one]( https://github.com/apache/httpcomponents-client/pull/253) while reading through some code and decided to check for others around our calls to `Buffer.array()`. It's relatively rare for array-backed buffers to have an offset since it requires a call to `Buffer.slice()`, but I it's safest to keep this in mind to prevent edge case failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] carterkozak merged pull request #220: HTTPCORE-648: Buffer array access respects the arrayOffset
Posted by GitBox <gi...@apache.org>.
carterkozak merged pull request #220:
URL: https://github.com/apache/httpcomponents-core/pull/220
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org