You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/23 17:59:31 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34071: [SPARK-36168][BUILD] Add support for Scala 2.13 in dev/test-dependencies.sh

dongjoon-hyun commented on a change in pull request #34071:
URL: https://github.com/apache/spark/pull/34071#discussion_r715031151



##########
File path: dev/test-dependencies.sh
##########
@@ -126,8 +121,8 @@ for HADOOP_HIVE_PROFILE in "${HADOOP_HIVE_PROFILES[@]}"; do
   dep_diff="$(
     git diff \
     --no-index \
-    dev/deps/spark-deps-$HADOOP_HIVE_PROFILE \
-    dev/pr-deps/spark-deps-$HADOOP_HIVE_PROFILE \
+    dev/deps/spark-deps-$HADOOP_HIVE_PROFILE-scala-$SCALA_BINARY_VERSION \

Review comment:
       I guess you need to rename the existing manifest files and to add new manifest files for Scala 2.13, @slothspot .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org