[PATCH] Fix XFail log test 20

[Senthil Kumaran S <se...@collab.net>]

Hi,

I am attaching a patch along with this mail to fix log test 20 which is 
marked as XFail test.

There are 3 XFail tests added to log_tests.py in r25175 (by lgo) to test 
the behavior of "svn log -c" command as given in the doc string of these 
tests. Since "-c" option accepts only a single revision number as of 
today (trunk r26785), I ve added this support for "svn log" command.

[[[
Fix XFail log test - log single change

  Add -c option to log command.

  * subversion/svn/main.c
    (main): Add --change subcommand to log command

  * subversion/tests/cmdline/log_tests.py
    (log_single_change): Tweak the revision numbers to be checked in the
     log chain.
    (test_list): Remove XFail tag from 'log_single_change'

  * subversion/tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout
    (main): Add --change description to "svn help log" stdout text

Patch by: Senthil Kumaran <se...@collab.net>
]]]

Am I missing something here? If so please let me know, since I could'nt 
get more info regarding these 3 XFail tests (the purpose) of 
log_tests.py other than the "svn log" message of r25175.

Thank You.

--
Senthil Kumaran S
http://www.stylesen.org/

Re: [PATCH] Fix XFail log test 20

[Eric Gillespie <ep...@google.com>]

Senthil Kumaran S <se...@collab.net> writes:

> I am attaching a patch along with this mail to fix log test 20 which is 
> marked as XFail test.
> 
> There are 3 XFail tests added to log_tests.py in r25175 (by lgo) to test 
> the behavior of "svn log -c" command as given in the doc string of these 
> tests. Since "-c" option accepts only a single revision number as of 
> today (trunk r26785), I ve added this support for "svn log" command.

> Index: subversion/tests/cmdline/log_tests.py
> ===================================================================
> --- subversion/tests/cmdline/log_tests.py	(revision 26785)
> +++ subversion/tests/cmdline/log_tests.py	(working copy)
> @@ -1159,7 +1159,7 @@
>    output, err = svntest.actions.run_and_verify_svn(None, None, [], 'log',
>                                                     '-c', 4, repo_url)
>    log_chain = parse_log_output(output)
> -  check_log_chain(log_chain, [4])
> +  check_log_chain(log_chain, [3, 4])

'-c 4' means the change from r3 to r4, so svn log -c 4 really
shouldn't show an entry for r3.  That's probably why this is
still an XFail; I looked at it once, but wasn't sure how to get
it to work.  Maybe we need to set something in the opt_state
indicating we had a -c not a -r?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org