You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/30 16:36:21 UTC

[GitHub] [arrow] pitrou commented on pull request #11014: ARROW-13775: [C++] Allow Partitioning objects to be created with a vector of field names

pitrou commented on pull request #11014:
URL: https://github.com/apache/arrow/pull/11014#issuecomment-908496393


   > This PR ended up being fairly extensive but mostly to avoid a single `shared_ptr` copy (due to changing the constructor to take in `const Schema& schema` instead of `std::shared_ptr<Schema>` since I now copy the field names and types out of the schema) and I'm not entirely sure that's worth it over just keeping the old interface.
   
   Just take `const std::shared_ptr<Schema>&` instead to minimize changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org