You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "AMashenkov (via GitHub)" <gi...@apache.org> on 2024/05/10 09:32:09 UTC
[PR] IGNITE-21941 Cover SQL F391(Long identifiers) feature by tests [ignite-3]
AMashenkov opened a new pull request, #3734:
URL: https://github.com/apache/ignite-3/pull/3734
https://issues.apache.org/jira/browse/IGNITE-21941
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21941 Cover SQL F391(Long identifiers) feature by tests [ignite-3]
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov merged PR #3734:
URL: https://github.com/apache/ignite-3/pull/3734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21941 Cover SQL F391(Long identifiers) feature by tests [ignite-3]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on code in PR #3734:
URL: https://github.com/apache/ignite-3/pull/3734#discussion_r1598286615
##########
modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test:
##########
@@ -0,0 +1,209 @@
+# name: sql/identifiers/test_long_identifiers.test
+# description: SQL feature F391 (Long identifiers)
+# group: [identifiers]
+
+# TODO: IGNITE-19703 Add cases for long identifiers for schema names.
+
+statement ok
+PRAGMA enable_verification
+
+# Create table with short identifiers for test simplicity purpose
+statement ok
+CREATE TABLE t (id INTEGER, val INTEGER, PRIMARY KEY (id))
+
+# Create table with long identifiers
+statement ok
+CREATE TABLE tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, valueColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, PRIMARY KEY (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters));
+
+statement error
+CREATE TABLE tableName_veryLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf129Characters (key INTEGER, val INTEGER, PRIMARY KEY (key));
+
+
+# Rename table with long identifiers
+# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed.
+# statement error
+# ALTER TABLE t RENAME TO tableName_veryLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf129Characters;
+# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed.
+# statement ok
+# ALTER TABLE t RENAME TO tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters;
+# TODO: Enable after https://issues.apache.org/jira/browse/IGNITE-19484 is fixed.
+# statement ok
+# ALTER TABLE tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters RENAME TO tableName;
+
+
+# Alter table add/drop column with long identifier
+statement ok
+ALTER TABLE t ADD COLUMN (columnName_veryLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER);
+
+statement error
+ALTER TABLE t ADD COLUMN (columnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf129Characters INTEGER);
+
+statement ok
+ALTER TABLE t DROP COLUMN (columnName_veryLooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters);
+
+
+# Alter table rename column with long identifier
+# TODO: IGNITE-19485, IGNITE-20315 - Uncomment this after column rename support gets aded.
Review Comment:
common pattern is to use : skipif, i.e.
```
skipif ignite3
# Ignored: https://issues.apache.org/jira/browse/IGNITE-xxxxx
query T
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-21941 Cover SQL F391(Long identifiers) feature by tests [ignite-3]
Posted by "lowka (via GitHub)" <gi...@apache.org>.
lowka commented on code in PR #3734:
URL: https://github.com/apache/ignite-3/pull/3734#discussion_r1598489377
##########
modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test:
##########
@@ -0,0 +1,209 @@
+# name: sql/identifiers/test_long_identifiers.test
+# description: SQL feature F391 (Long identifiers)
+# group: [identifiers]
+
+# TODO: IGNITE-19703 Add cases for long identifiers for schema names.
+
+statement ok
+PRAGMA enable_verification
+
+# Create table with short identifiers for test simplicity purpose
+statement ok
+CREATE TABLE t (id INTEGER, val INTEGER, PRIMARY KEY (id))
+
+# Create table with long identifiers
+statement ok
+CREATE TABLE tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, valueColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, PRIMARY KEY (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters));
+
+statement error
Review Comment:
Could you please include an error message check here ? I can be done by using the following syntax
> statement error: Blah blah blah
> SELECT WRONG
##########
modules/sql-engine/src/integrationTest/sql/identifiers/test_long_identifiers.test:
##########
@@ -0,0 +1,209 @@
+# name: sql/identifiers/test_long_identifiers.test
+# description: SQL feature F391 (Long identifiers)
+# group: [identifiers]
+
+# TODO: IGNITE-19703 Add cases for long identifiers for schema names.
+
+statement ok
+PRAGMA enable_verification
+
+# Create table with short identifiers for test simplicity purpose
+statement ok
+CREATE TABLE t (id INTEGER, val INTEGER, PRIMARY KEY (id))
+
+# Create table with long identifiers
+statement ok
+CREATE TABLE tableName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, valueColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters INTEGER, PRIMARY KEY (keyColumnName_veryLoooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooongIdentifierOf128Characters));
+
+statement error
Review Comment:
Could you please include an error message check here ? It can be done by using the following syntax
> statement error: Blah blah blah
> SELECT WRONG
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org