You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2018/10/19 08:06:39 UTC
Review Request 69081: RANGER-2258 Improve the policy list page to
prompt users when the service is disabled
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69081/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy.
Bugs: RANGER-2258
https://issues.apache.org/jira/browse/RANGER-2258
Repository: ranger
Description
-------
After disabling the service, the policy list page displays "No Policies found!", the user can still add policies, but the page still displays 'No Policies found!', which may cause user confusion.
Modify the prompt message to “No Policies found! The service is disabled!” and hide the “Add new policy” button when the service is disabled.
Modified screenshots:
https://issues.apache.org/jira/secure/attachment/12944673/Modify.PNG
Diffs
-----
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 115083881
security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bcd495cf6
Diff: https://reviews.apache.org/r/69081/diff/1/
Testing
-------
Test Result:
Tested.
Thanks,
Qiang Zhang
Re: Review Request 69081: RANGER-2258 Improve the policy list page to
prompt users when the service is disabled
Posted by Nitin Galave <ni...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69081/#review209918
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Galave
On Oct. 19, 2018, 8:06 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69081/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2018, 8:06 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2258
> https://issues.apache.org/jira/browse/RANGER-2258
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After disabling the service, the policy list page displays "No Policies found!", the user can still add policies, but the page still displays 'No Policies found!', which may cause user confusion.
> Modify the prompt message to “No Policies found! The service is disabled!” and hide the “Add new policy” button when the service is disabled.
>
> Modified screenshots:
>
> https://issues.apache.org/jira/secure/attachment/12944673/Modify.PNG
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 115083881
> security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bcd495cf6
>
>
> Diff: https://reviews.apache.org/r/69081/diff/1/
>
>
> Testing
> -------
>
> Test Result:
>
> Tested.
>
>
> Thanks,
>
> Qiang Zhang
>
>
Re: Review Request 69081: RANGER-2258 Improve the policy list page to
prompt users when the service is disabled
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69081/#review209912
-----------------------------------------------------------
Ship it!
Ship It!
- pengjianhua
On 十月 19, 2018, 8:06 a.m., Qiang Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69081/
> -----------------------------------------------------------
>
> (Updated 十月 19, 2018, 8:06 a.m.)
>
>
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Nitin Galave, pengjianhua, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2258
> https://issues.apache.org/jira/browse/RANGER-2258
>
>
> Repository: ranger
>
>
> Description
> -------
>
> After disabling the service, the policy list page displays "No Policies found!", the user can still add policies, but the page still displays 'No Policies found!', which may cause user confusion.
> Modify the prompt message to “No Policies found! The service is disabled!” and hide the “Add new policy” button when the service is disabled.
>
> Modified screenshots:
>
> https://issues.apache.org/jira/secure/attachment/12944673/Modify.PNG
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js 115083881
> security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html bcd495cf6
>
>
> Diff: https://reviews.apache.org/r/69081/diff/1/
>
>
> Testing
> -------
>
> Test Result:
>
> Tested.
>
>
> Thanks,
>
> Qiang Zhang
>
>