[GitHub] [trafficserver] bneradt commented on a diff in pull request #10189: Fixing TSHttpTxnServerAddrSet

["bneradt (via GitHub)" <gi...@apache.org>]

bneradt commented on code in PR #10189:
URL: https://github.com/apache/trafficserver/pull/10189#discussion_r1296100133


##########
proxy/http/HttpSM.cc:
##########
@@ -7832,7 +7832,8 @@ HttpSM::set_next_state()
       t_state.dns_info.resolved_p = true; // seems dangerous - where's the IP address?
       call_transact_and_set_next_state(nullptr);
       break;
-    } else if (t_state.parent_result.result == PARENT_UNDEFINED && t_state.dns_info.resolve_immediate()) {
+    } else if (t_state.dns_info.resolved_p) {
+      SMDebug("dns", "Skipping DNS lookup because the address is already set.");

Review Comment:
   Correct. Yahoo's internal plugin relies upon redirecting after CACHE_LOOKUP_COMPLETE in order to work. Fortunately it seems to work. :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org