You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Hannah Jiang (Jira)" <ji...@apache.org> on 2019/09/17 00:45:00 UTC
[jira] [Comment Edited] (BEAM-8165) Change image name and add
images to release process
[ https://issues.apache.org/jira/browse/BEAM-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930981#comment-16930981 ]
Hannah Jiang edited comment on BEAM-8165 at 9/17/19 12:44 AM:
--------------------------------------------------------------
Originally, we used *$\{System.properties["user.name"]}-docker-apache.bintray.io/beam* as a default docker root for all images. These images are only named like way, they are not really published to Bintray.
As we want to publish SDK harness images to docker hub, we decided to use *apachebeam* as default docker image root.
This means we need to support two different roots for different type of images. (SDK harness images vs other images) The reason we keep as it is for now is given short deadline of 2.16, it's difficult to investigate all impact with default root change.
The solution is keeping *$\{System.properties["user.name"]}-docker-apache.bintray.io/beam* as * *a* * default root, and pass apachebeam with docker-repository-root variable when we create SDK images.
Default root will be overwritten by the root passed by docker-repository-root .
PR 9487 changed the default root to apachebeam, so when we create Flink image, it is named apachebeam/xxx, which caused test failures.
For long term, we should make it consistent for all images for easy maintenance. BEAM-8250 is created for long term work.
was (Author: hannahjiang):
Originally, we used *${System.properties["user.name"]}-docker-apache.bintray.io/beam* as a default docker root for all images. These images are only named like way, they are not really published to Bintray.
As we want to publish SDK harness images to docker hub, we decided to use *apachebeam* as default docker image root.
This means we need to support two different roots for different type of images. (SDK harness images vs other images) The reason we keep as it is for now is given short deadline of 2.16, it's difficult to investigate all impact with default root change.
The solution is keeping *${System.properties["user.name"]}-docker-apache.bintray.io/beam* as ** a ** default root, and pass apachebeam with docker-repository-root variable when we create SDK images.
Default root will be overwritten by the root passed by docker-repository-root .
For long term, we should make it consistent for all images for easy maintenance. BEAM-8250 is created for long term work.
> Change image name and add images to release process
> ---------------------------------------------------
>
> Key: BEAM-8165
> URL: https://issues.apache.org/jira/browse/BEAM-8165
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go, sdk-java-harness, sdk-py-harness
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Blocker
> Fix For: 2.16.0
>
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> change name to apachebeam/\{lang} \{ver}_sdk
> Images are published to [https://hub.docker.com/u/apachebeam].
--
This message was sent by Atlassian Jira
(v8.3.2#803003)