[GitHub] [hive] abstractdog commented on a diff in pull request #3607: HIVE-26529: Iceberg: Fix VectorizedSupport support for DECIMAL_64 in HiveIcebergInputFormat.

[GitBox <gi...@apache.org>]

abstractdog commented on code in PR #3607:
URL: https://github.com/apache/hive/pull/3607#discussion_r976692639


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -826,6 +834,18 @@ private Type.PrimitiveType getPrimitiveTypeOrThrow(FieldSchema field) throws Met
     return (Type.PrimitiveType) newType;
   }
 
+  private void setOrcOnlyFilesParam(org.apache.hadoop.hive.metastore.api.Table hmsTable) {
+    if (org.apache.iceberg.FileFormat.ORC.name().equalsIgnoreCase(hmsTable.getSd().getInputFormat()) ||

Review Comment:
   nit: what about refactoring this huge condition to a method? (it can be even reused later)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org