You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/15 02:42:24 UTC

[GitHub] [pulsar] Jason918 commented on pull request #17228: [fix][storage] refresh the ledgers map when the offload complete failed

Jason918 commented on PR #17228:
URL: https://github.com/apache/pulsar/pull/17228#issuecomment-1247511287

   > For example, we update the ledgers map in memory after successfully updating the LedgerInfo in the zookeeper . If the zookeeper update operation executes successfully on server but throws connection loss on the client, and we have to retry on the connection loss exception, then the callback may receive a BadVersion exception. At this moment, the memory ledgers list is different from the zookeeper server. And that may cause some other issues on the broker.
   
   @zymap 
   I wonder why don't handle this case in metadata, retry the write operation if we got BadVersion after a Connection loss, to avoid throwing the exception to broker module. And so that this fix can apply to other metadata writes too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org