[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1171: feat: add config for log cleaner

[GitBox <gi...@apache.org>]

git-hulk commented on code in PR #1171:
URL: https://github.com/apache/incubator-kvrocks/pull/1171#discussion_r1050483268


##########
kvrocks.conf:
##########
@@ -96,6 +96,15 @@ dir /tmp/kvrocks
 # We also can send logs to stdout/stderr is as simple as:
 #
 log-dir stdout
+# log-dir log
+
+# You can configure logcleanerday to control whether to enable logcleaner
+# and the maximum number of days that the INFO level logs will be kept.
+# if set logcleanerday to -1 , this mean disable logcleaner.
+# if set logcleanerday between 0 to INT_MAX , this mean enable logcleaner ,
+# and INFO level log file whose last modified time is greater than logcleanerday will be unlinked.
+# By default the logcleanerday is -1.
+logcleanerday -1

Review Comment:
   Thanks for your re-claimed, it'd be better if it could remove all level logs instead of only the INFO level.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org