You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jor (JIRA)" <ji...@apache.org> on 2009/04/07 12:53:12 UTC
[jira] Created: (WICKET-2214) Form tag in modal window html code
(modal.js -> Wicket.Window.getMarkup)
Form tag in modal window html code (modal.js -> Wicket.Window.getMarkup)
-------------------------------------------------------------------------
Key: WICKET-2214
URL: https://issues.apache.org/jira/browse/WICKET-2214
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.3.5
Reporter: Jor
There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when modal window is used with panels that contain forms.
I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-2214:
-------------------------------------
Assignee: Matej Knopp
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Assignee: Matej Knopp
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Farhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848603#action_12848603 ]
Farhan commented on WICKET-2214:
--------------------------------
I am getting a scripting error in IE when using YUI DatePicker. The DatePicker is part of a form contained within a panel, and the panel is rendered in a modal-window. As suggested by Matej/Gabriel, (and as per the ModalWindow javadocs) I added the modal-window itself in another wicket form. Now that does resolve the DatePicker scripting-error, but my form within the panel is no longer working as expected.
Strangely, enclosing the modal-window in another form results in the form tag (within the panel) getting replaced by a <div> tag in the resulting page, with onSubmit() event attached to it, which is weird, and hence the Submit button reacts to the (default) form part of the modal window implementation, which is the very parent form in the hierarchy.
Below is the <div> tag with the onsubmit event which i am referring to above, which really should be a <form> tag, as it was before i tried the solution.
<div id="id269" onsubmit="var wcall=wicketSubmitFormById('id269', '?x=l*F2Z-vvlsgtuteLhpGYqUP-p0Prju6WvbPKvK5rCXmocNnl4xgDlMC2oiv7jeApNIdJJUpaJoLpF10SUaMz1QALvs4BdU5NUjwPEIYl0WlBchN86VEYhYQ0N5EbaYaPgRY*F0cYbevfcrN2TJfXJMi4phSfh59YXU5VUWXtZhvdFoEfo0KksqlpIxqO6U*8', null,null,null, function() {return Wicket.$$(this)&&Wicket.$$('id269')}.bind(this));return false;;">
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Assignee: Matej Knopp
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Marcin Palka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738427#action_12738427 ]
Marcin Palka commented on WICKET-2214:
--------------------------------------
Same here. I've got a modal window with an ajaxtabbed panel inside. Each tab contains a form. In my case the form tag on the 2nd tab does not get rendered. It looks like somehow only contents of the form are being rendered. I can see proper html being send in a ajax response but it does not get rendered properly.
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Assignee: Matej Knopp
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Jor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jor updated WICKET-2214:
------------------------
Component/s: (was: wicket)
Description:
There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
I had to replace it with div tag to get my panel working.
was:
There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when modal window is used with panels that contain forms.
I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
I had to replace it with div tag to get my panel working.
Affects Version/s: 1.4-M1
1.4-M2
1.4-M3
1.4-RC1
1.4-RC2
Summary: Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms (was: Form tag in modal window html code (modal.js -> Wicket.Window.getMarkup))
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.4-M1, 1.4-M2, 1.4-M3, 1.4-RC1, 1.4-RC2
> Reporter: Jor
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-2214.
-----------------------------------
Assignee: Igor Vaynberg (was: Matej Knopp)
Resolution: Invalid
you will not end up with double form tags in your hierarchy. like the javadoc says if you use content panels that contain forms then put the modal itself into a form, which will cause your content forms to be rendered as <divs> since now they will be considered inner forms by wicket.
the markup the modal generates is added under the body element, not where it is added in the markup, so you will never have double form tags.
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Assignee: Igor Vaynberg
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Jonathan Hewer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765027#action_12765027 ]
Jonathan Hewer commented on WICKET-2214:
----------------------------------------
Matej, could you please clarify why it is necessary for the modal window to be placed within a form, when it contains a form itself? The patch solves the immediate issue for me, however I'd like to know whether there will be any side effects of replacing the outer form with a div. Thanks.
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Assignee: Matej Knopp
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Gabriel LANDON (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765167#action_12765167 ]
Gabriel LANDON commented on WICKET-2214:
----------------------------------------
It's written in the javadoc of the ModalWindow :
*...
* If you want to use form in modal window component make sure that you put the modal window itself
* in another form (nesting forms is legal in Wicket).
*
* @see IPageSettings#setAutomaticMultiWindowSupport(boolean)
* @author Matej Knopp
*/
Putting the ModalWindow inside a form also solve the problem of the DatePicker not displaying properly with IE.
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Assignee: Matej Knopp
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Zoltán Nagy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726903#action_12726903 ]
Zoltán Nagy commented on WICKET-2214:
-------------------------------------
I have the same problem. I have a ModalWindow and a Wizard with AjaxButtons.
Whern I show the ModalWindow it sends back the content with correct form tag. The Firefox (Iceweasel 2.0.0.17) insert this with the client side generated ModalWindow markup.
When I click an AjaxButton ("Next >" for example) my AjaxWizard component sends back the full ModalWindow in the ajax response. It contains the correct form tag of the Wizard. But this form tag (and only the form tag) disappears while client side js inserts it to the document dom structure. So the outer extra form tag take over the wizard's form role. From this point the ajax callback codes references to an unexist form id...
As a workaround I have done the following: on startup I load the modal.js resource, modify it and register as a shared resource:
// import org.apache.commons.lang.StringUtils;
private void fixModalWindowFormError() {
final String scopeName = "org.apache.wicket.extensions.ajax.markup.html.modal.ModalWindow";
final String name = "res/modal.js";
InputStream inputStream = null;
try {
// get Content
String content = null;
IResourceStream resourceStream;
StringBuilder sb = new StringBuilder();
char[] buffer = new char[16834];
PackageResource sourceRsc = PackageResource.get(Classes.resolveClass(scopeName), name);
resourceStream = sourceRsc.getResourceStream();
inputStream = resourceStream.getInputStream();
InputStreamReader inputStreamReader = new InputStreamReader(inputStream, Charset.forName("ascii"));
while (true) {
int read = inputStreamReader.read(buffer);
if (read == -1) {
break;
}
sb.append(buffer, 0, read);
}
// filter out <form> tag
content = sb.toString();
content = StringUtils.replaceEach(content, new String[]{"<form", "</form"}, new String[]{"<div", "</div"});
// store sharedResource
ByteArrayResource targetRsc = new ByteArrayResource(resourceStream.getContentType(), content.getBytes(Charset.forName("ascii")));
getSharedResources().add(Classes.resolveClass(scopeName), name, null, null, targetRsc);
} catch (IOException ex) {
log.error("", ex);
} catch (ResourceStreamNotFoundException ex) {
log.error("", ex);
} finally {
try {
inputStream.close();
} catch (IOException ex) {
log.error("", ex);
}
}
}
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Assignee: Matej Knopp
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738433#action_12738433 ]
Matej Knopp commented on WICKET-2214:
-------------------------------------
If you have form inside your modal window the modal window itself needs to be placed in another form.
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Assignee: Matej Knopp
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2214) Form tag in ModalWindow html code
causes nested html forms when ModalWindow is used with panel that contain
forms
Posted by "Jor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jor updated WICKET-2214:
------------------------
Affects Version/s: (was: 1.4-RC1)
(was: 1.4-M3)
(was: 1.4-M2)
(was: 1.4-M1)
1.3.6
> Form tag in ModalWindow html code causes nested html forms when ModalWindow is used with panel that contain forms
> -----------------------------------------------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5, 1.3.6, 1.4-RC2
> Reporter: Jor
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when ModalWindow is used with panel that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2214) Form tag in modal window html code
(modal.js -> Wicket.Window.getMarkup)
Posted by "Jor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jor updated WICKET-2214:
------------------------
Attachment: modal.js.patch
> Form tag in modal window html code (modal.js -> Wicket.Window.getMarkup)
> -------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.3.5
> Reporter: Jor
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when modal window is used with panels that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-2214) Form tag in modal window html code
(modal.js -> Wicket.Window.getMarkup)
Posted by "Jor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jor updated WICKET-2214:
------------------------
Component/s: wicket
> Form tag in modal window html code (modal.js -> Wicket.Window.getMarkup)
> -------------------------------------------------------------------------
>
> Key: WICKET-2214
> URL: https://issues.apache.org/jira/browse/WICKET-2214
> Project: Wicket
> Issue Type: Bug
> Components: wicket, wicket-extensions
> Affects Versions: 1.3.5
> Reporter: Jor
> Attachments: modal.js.patch
>
>
> There is an extra form tag in modal window html code (modal.js -> Wicket.Window.getMarkup function), it causes problems when modal window is used with panels that contain forms.
> I haven't found any use for that form tag as it cannot be referenced from java code (it has no wicket id) and it only causes problems by creating nested form tags (outter form from modal html with no wicket id and inner form from panel with wicket id) that some browsers cant handle and its againts W3C html specification.
> I had to replace it with div tag to get my panel working.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.