You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/05/15 17:06:26 UTC

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh 

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13335


Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................

Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh

This does a basic debug build with USE_CDP_HIVE=true to verify we don't
break anything.

Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
---
M bin/jenkins/build-all-flag-combinations.sh
1 file changed, 10 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/13335/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................

Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh

This does a basic debug build with USE_CDP_HIVE=true to verify we don't
break anything.

Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Reviewed-on: http://gerrit.cloudera.org:8080/13335
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/jenkins/build-all-flag-combinations.sh
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4267/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2019 18:53:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4277/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2019 18:16:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................


Patch Set 1:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4267/


-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 May 2019 00:22:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2019 23:30:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2019 03:38:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................


Patch Set 1:

The job that calls build-all-flag-combinations.sh passed, not sure why the other job failed.


-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2019 17:07:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................


Patch Set 2: Code-Review+2

Rebased, carry +2


-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 17 May 2019 18:15:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add USE CDP HIVE=true case to build-all-flag-combinations.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13335 )

Change subject: Add USE_CDP_HIVE=true case to build-all-flag-combinations.sh
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3236/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f8e689242e20efb37fbadf7c04764ea8ffb9a9f
Gerrit-Change-Number: 13335
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 May 2019 18:05:33 +0000
Gerrit-HasComments: No