[jira] [Commented] (OOZIE-1740) Add a new function hadoop:conf() that can be invoked from the workflow.xml and will return a hadoop configuration option

["Robert Kanter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980266#comment-13980266 ] 

Robert Kanter commented on OOZIE-1740:
--------------------------------------

Can you rebase the patch on the latest trunk?  Also, you don't need to edit release-log.txt when posting a patch; the committer will take care of that when committing it.  And please use the {{--no-prefix}} option in {{git diff}} when generating the patch so the paths don't start with 'a' and 'b' (e.g. we want {{core/src/main/...}} and not {{a/core/src/main/...}}).  

Here's some feedback on the patch itself:
1. When creating the {{File}} objects, you don't have to bother with the {{File.separator}} if you do {{new File(path, filename)}}
2. Can you add some way of using the configs that Oozie is using for the workflow?  i.e. the stuff defined in the {{oozie.service.HadoopAccessorService.hadoop.configurations}} property in oozie-site?  Otherwise, users have to know exactly where their configs are on the Oozie server and is also less portable.  If there's some way to specify the config that Oozie will be using for the workflow, then the user doesn't have to know anything.  I think the easiest would be instead of making it so that when "hadoopConfPath" is null or "" that it uses the default config, it should use the config Oozie is using.  Let me know if this isn't clear.
3. It might also be helpful to make this EL function available in Coordinators too

> Add a new function hadoop:conf() that can be invoked from the workflow.xml and will return a hadoop configuration option
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OOZIE-1740
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1740
>             Project: Oozie
>          Issue Type: Improvement
>          Components: workflow
>    Affects Versions: trunk, 3.3.2
>            Reporter: sam liu
>         Attachments: OOZIE-1740.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)