You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Chinmay Kulkarni (Jira)" <ji...@apache.org> on 2020/07/16 20:10:00 UTC

[jira] [Commented] (PHOENIX-6017) Hadoop QA Precommit build keeps failing with release audit warning for phoenix-server/dependency-reduced-pom.xml

    [ https://issues.apache.org/jira/browse/PHOENIX-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159446#comment-17159446 ] 

Chinmay Kulkarni commented on PHOENIX-6017:
-------------------------------------------

The patch seems simple, but not sure if there are any undesirable side-effects. Can you please take a look [~stoty]?

> Hadoop QA Precommit build keeps failing with release audit warning for phoenix-server/dependency-reduced-pom.xml
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6017
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6017
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.0.0, 4.15.0
>            Reporter: Chinmay Kulkarni
>            Assignee: Istvan Toth
>            Priority: Major
>              Labels: beginner, newbie, phoenix-hardening, quality-improvement
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-6017-4.x-v1.patch
>
>
> I believe this is introduced by some changes related to the maven-shaded plugin. We create a dependency-reduced-pom.xml which is considered during the license header check, thus always causing preCommit to fail on this step. We should prevent its creation perhaps via something like [this|https://stackoverflow.com/questions/11314182/maven-shade-plugin-adding-dependency-reduced-pom-xml-to-base-directory]. Example of a failing build's error:
> {code:java}
> 1 Unknown Licenses
> *****************************************************
> Files with unapproved licenses:
>   /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-server/dependency-reduced-pom.xml
> *****************************************************
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)