You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/10/01 21:02:42 UTC

[kudu-CR] AsyncKuduClient: improve debug-level getTableKeyRanges logging 

Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/14336

to review the following change.


Change subject: AsyncKuduClient: improve debug-level getTableKeyRanges logging
......................................................................

AsyncKuduClient: improve debug-level getTableKeyRanges logging

We've been seeing the occasional TestSplitKeyRange failure that's hard to
debug because the test makes multiple getTableKeyRanges() calls and it's not
clear to which call each line of output applies.

Change-Id: I5efb5b04db725741f20ec6b1b64849b029ce6db3
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/14336/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5efb5b04db725741f20ec6b1b64849b029ce6db3
Gerrit-Change-Number: 14336
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>

[kudu-CR] AsyncKuduClient: improve debug-level getTableKeyRanges logging

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14336 )

Change subject: AsyncKuduClient: improve debug-level getTableKeyRanges logging
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5efb5b04db725741f20ec6b1b64849b029ce6db3
Gerrit-Change-Number: 14336
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 01:41:25 +0000
Gerrit-HasComments: No

[kudu-CR] AsyncKuduClient: improve debug-level getTableKeyRanges logging

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14336 )

Change subject: AsyncKuduClient: improve debug-level getTableKeyRanges logging
......................................................................

AsyncKuduClient: improve debug-level getTableKeyRanges logging

We've been seeing the occasional TestSplitKeyRange failure that's hard to
debug because the test makes multiple getTableKeyRanges() calls and it's not
clear to which call each line of output applies.

Change-Id: I5efb5b04db725741f20ec6b1b64849b029ce6db3
Reviewed-on: http://gerrit.cloudera.org:8080/14336
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5efb5b04db725741f20ec6b1b64849b029ce6db3
Gerrit-Change-Number: 14336
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)