You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2011/09/04 07:14:09 UTC
[jira] [Commented] (ZOOKEEPER-1136) NEW_LEADER should be queued not
sent to match the Zab 1.0 protocol on the twiki
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096814#comment-13096814 ]
Hadoop QA commented on ZOOKEEPER-1136:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12492950/ZOOKEEPER-1136.patch
against trunk revision 1164758.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/498//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/498//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/498//console
This message is automatically generated.
> NEW_LEADER should be queued not sent to match the Zab 1.0 protocol on the twiki
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1136
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1136
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Benjamin Reed
> Assignee: Benjamin Reed
> Priority: Blocker
> Fix For: 3.3.4, 3.4.0
>
> Attachments: ZOOKEEPER-1136.patch, ZOOKEEPER-1136.patch, ZOOKEEPER-1136.patch
>
>
> the NEW_LEADER message was sent at the beginning of the sync phase in Zab pre1.0, but it must be at the end in Zab 1.0. if the protocol is 1.0 or greater we need to queue rather than send the packet.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira