You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/06 03:43:32 UTC
[GitHub] [incubator-superset] mistercrunch opened a new pull request #11168: fix: docs/api won't render
mistercrunch opened a new pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168
It's unclear to me exactly why, but docz is flimsy with the way
things are named and runs into odd collision and error messages.
Somehow renaming the route seem to help. Jut rolling with it after many
`gatsby clean`
Also fixing a few warnings here while I'm at it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#issuecomment-704507031
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@152315d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11168 +/- ##
=========================================
Coverage ? 61.70%
=========================================
Files ? 828
Lines ? 39116
Branches ? 3688
=========================================
Hits ? 24137
Misses ? 14798
Partials ? 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (?)` | |
| #python | `61.34% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=footer). Last update [152315d...796ffcb](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11168: fix: docs/api won't render
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#discussion_r499989351
##########
File path: docs/src/pages/docs/api.mdx
##########
@@ -1,7 +1,7 @@
---
name: API
title: API
-route: /docs/api
+route: /docs/rest-api
Review comment:
This is the hack/workaround, I was getting collision warnings on `/docs/api` vs `/docs/api/`, page wouldn't render (though in the past it did). This one line change plus a `gastby clear` / restart seem to fix it all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11168: fix: docs/api won't render
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#discussion_r499989351
##########
File path: docs/src/pages/docs/api.mdx
##########
@@ -1,7 +1,7 @@
---
name: API
title: API
-route: /docs/api
+route: /docs/rest-api
Review comment:
This is the hack/workaround, I was getting collision warnings on `/docs/api` vs `/docs/api/`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#discussion_r500004996
##########
File path: .github/workflows/superset-python.yml
##########
@@ -1,14 +1,6 @@
# Python unit tests
name: Python
-on:
- push:
- paths-ignore:
- - 'docs/**'
- pull_request:
- paths-ignore:
- - 'docs/**'
-
Review comment:
This should become:
`on: [push, pull_request]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#issuecomment-704507031
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@152315d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11168 +/- ##
=========================================
Coverage ? 61.24%
=========================================
Files ? 828
Lines ? 39116
Branches ? 3688
=========================================
Hits ? 23957
Misses ? 14978
Partials ? 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (?)` | |
| #python | `60.61% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=footer). Last update [152315d...796ffcb](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#issuecomment-704507031
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@152315d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11168 +/- ##
=========================================
Coverage ? 60.28%
=========================================
Files ? 391
Lines ? 24474
Branches ? 0
=========================================
Hits ? 14754
Misses ? 9720
Partials ? 0
```
| Flag | Coverage Δ | |
|---|---|---|
| #python | `60.28% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=footer). Last update [152315d...796ffcb](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#issuecomment-704507031
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@152315d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #11168 +/- ##
=========================================
Coverage ? 61.59%
=========================================
Files ? 828
Lines ? 39116
Branches ? 3688
=========================================
Hits ? 24092
Misses ? 14843
Partials ? 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.30% <ø> (?)` | |
| #python | `61.16% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=footer). Last update [152315d...796ffcb](https://codecov.io/gh/apache/incubator-superset/pull/11168?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#discussion_r500004894
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -1,13 +1,5 @@
name: E2E
-on:
- push:
- paths-ignore:
- - 'docs/**'
- pull_request:
- paths-ignore:
- - 'docs/**'
-
Review comment:
To revert, this should become:
`on: [push, pull_request]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#discussion_r500005141
##########
File path: .github/workflows/test-presto.yml
##########
@@ -1,13 +1,5 @@
name: Presto
-on:
- push:
- paths-ignore:
- - 'docs/**'
- pull_request:
- paths-ignore:
- - 'docs/**'
Review comment:
Should become `on: [push, pull_request]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11168: fix: 📜 `/docs/api` won't render
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11168:
URL: https://github.com/apache/incubator-superset/pull/11168#discussion_r500005083
##########
File path: .github/workflows/test-hive.yml
##########
@@ -1,13 +1,5 @@
name: Hive
-on:
- push:
- paths-ignore:
- - 'docs/**'
- pull_request:
- paths-ignore:
- - 'docs/**'
-
Review comment:
Should become `on: [push, pull_request]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org