You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/21 21:16:32 UTC

[GitHub] [incubator-tvm] tmoreau89 opened a new pull request #6731: [Draft] Quantization support for more ops

tmoreau89 opened a new pull request #6731:
URL: https://github.com/apache/incubator-tvm/pull/6731


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] ZihengJiang commented on pull request #6731: [Draft] Quantization support for more ops

Posted by GitBox <gi...@apache.org>.
ZihengJiang commented on pull request #6731:
URL: https://github.com/apache/incubator-tvm/pull/6731#issuecomment-713899153


   @tmoreau89 It is ok if you have verified that this PR doesn't affect the accuracy of common quantized models


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6731: [Draft] Quantization support for more ops

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #6731:
URL: https://github.com/apache/incubator-tvm/pull/6731#issuecomment-713900010


   I did a spot check on a model that we're quantizing. Also ran some validation over a CIFAR-10 model from MxNet.
   
   I'll change it to a PR for review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6731: [Draft] Quantization support for more ops

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #6731:
URL: https://github.com/apache/incubator-tvm/pull/6731#issuecomment-713882790


   @ZihengJiang I want to add more coverage for the quantizer, do we generally add unit tests when adding more ops or is this PR sufficient?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #6731: [Draft] Quantization support for more ops

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #6731:
URL: https://github.com/apache/incubator-tvm/pull/6731#issuecomment-713901749


   thanks @ZihengJiang @vinx13 PTAL!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] vinx13 merged pull request #6731: [Quantization] Support for more ops (conv1d)

Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #6731:
URL: https://github.com/apache/incubator-tvm/pull/6731


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org