You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "szymon-czapracki (via GitHub)" <gi...@apache.org> on 2024/08/09 10:05:17 UTC
[PR] nimble/audio/bass: Modify remove source operation [mynewt-nimble]
szymon-czapracki opened a new pull request, #1839:
URL: https://github.com/apache/mynewt-nimble/pull/1839
Fix event type in ble_audio_event structure.
Modify data for use with new mbuf.
Add characteristic value in receive state.
Remove goto pointing to goto itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/audio/bass: Modify remove source operation [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1839:
URL: https://github.com/apache/mynewt-nimble/pull/1839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/audio/bass: Modify remove source operation [mynewt-nimble]
Posted by "szymon-czapracki (via GitHub)" <gi...@apache.org>.
szymon-czapracki commented on code in PR #1839:
URL: https://github.com/apache/mynewt-nimble/pull/1839#discussion_r1727282074
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -549,18 +549,20 @@ static int
ble_svc_audio_bass_remove_source(uint8_t *data, uint16_t data_len, uint16_t conn_handle)
{
struct ble_audio_event ev = {
- .type = BLE_AUDIO_EVENT_BASS_BROADCAST_CODE_SET,
+ .type = BLE_AUDIO_EVENT_BASS_OPERATION_STATUS,
.bass_operation_status = {
.op = BLE_AUDIO_EVENT_BASS_SOURCE_REMOVED,
.status = 0
}
};
struct ble_svc_audio_bass_rcv_state_entry *rcv_state = NULL;
struct ble_svc_audio_bass_operation operation;
+ uint16_t chr_val;
Review Comment:
Done
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -549,18 +549,20 @@ static int
ble_svc_audio_bass_remove_source(uint8_t *data, uint16_t data_len, uint16_t conn_handle)
{
struct ble_audio_event ev = {
- .type = BLE_AUDIO_EVENT_BASS_BROADCAST_CODE_SET,
+ .type = BLE_AUDIO_EVENT_BASS_OPERATION_STATUS,
.bass_operation_status = {
.op = BLE_AUDIO_EVENT_BASS_SOURCE_REMOVED,
.status = 0
}
};
struct ble_svc_audio_bass_rcv_state_entry *rcv_state = NULL;
struct ble_svc_audio_bass_operation operation;
+ uint16_t chr_val;
int rc = 0;
int i;
- ev.bass_set_broadcast_code.source_id = data[0];
+ ev.bass_set_broadcast_code.source_id = data[1];
+ operation.op = BLE_SVC_AUDIO_BASS_OPERATION_REMOVE_SOURCE;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/audio/bass: Modify remove source operation [mynewt-nimble]
Posted by "szymon-czapracki (via GitHub)" <gi...@apache.org>.
szymon-czapracki commented on code in PR #1839:
URL: https://github.com/apache/mynewt-nimble/pull/1839#discussion_r1727282947
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -587,12 +589,12 @@ ble_svc_audio_bass_remove_source(uint8_t *data, uint16_t data_len, uint16_t conn
memset(rcv_state, 0, sizeof(*rcv_state));
rcv_state->source_id = BLE_SVC_AUDIO_BASS_RECEIVE_STATE_SRC_ID_NONE;
+ rcv_state->chr_val = chr_val;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/audio/bass: Modify remove source operation [mynewt-nimble]
Posted by "MariuszSkamra (via GitHub)" <gi...@apache.org>.
MariuszSkamra commented on code in PR #1839:
URL: https://github.com/apache/mynewt-nimble/pull/1839#discussion_r1721494251
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -549,18 +549,20 @@ static int
ble_svc_audio_bass_remove_source(uint8_t *data, uint16_t data_len, uint16_t conn_handle)
{
struct ble_audio_event ev = {
- .type = BLE_AUDIO_EVENT_BASS_BROADCAST_CODE_SET,
+ .type = BLE_AUDIO_EVENT_BASS_OPERATION_STATUS,
.bass_operation_status = {
.op = BLE_AUDIO_EVENT_BASS_SOURCE_REMOVED,
.status = 0
}
};
struct ble_svc_audio_bass_rcv_state_entry *rcv_state = NULL;
struct ble_svc_audio_bass_operation operation;
+ uint16_t chr_val;
int rc = 0;
int i;
- ev.bass_set_broadcast_code.source_id = data[0];
+ ev.bass_set_broadcast_code.source_id = data[1];
+ operation.op = BLE_SVC_AUDIO_BASS_OPERATION_REMOVE_SOURCE;
Review Comment:
ditto
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -549,18 +549,20 @@ static int
ble_svc_audio_bass_remove_source(uint8_t *data, uint16_t data_len, uint16_t conn_handle)
{
struct ble_audio_event ev = {
- .type = BLE_AUDIO_EVENT_BASS_BROADCAST_CODE_SET,
+ .type = BLE_AUDIO_EVENT_BASS_OPERATION_STATUS,
.bass_operation_status = {
.op = BLE_AUDIO_EVENT_BASS_SOURCE_REMOVED,
.status = 0
}
};
struct ble_svc_audio_bass_rcv_state_entry *rcv_state = NULL;
struct ble_svc_audio_bass_operation operation;
+ uint16_t chr_val;
Review Comment:
indent
##########
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c:
##########
@@ -587,12 +589,12 @@ ble_svc_audio_bass_remove_source(uint8_t *data, uint16_t data_len, uint16_t conn
memset(rcv_state, 0, sizeof(*rcv_state));
rcv_state->source_id = BLE_SVC_AUDIO_BASS_RECEIVE_STATE_SRC_ID_NONE;
+ rcv_state->chr_val = chr_val;
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org