You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Animesh Chaturvedi <an...@citrix.com> on 2013/02/15 18:57:15 UTC
RE: Review Request: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Nitin
Any updates? Please commit the patch if satisfied.
Animesh
> -----Original Message-----
> From: Rohit Yadav [mailto:noreply@reviews.apache.org] On Behalf Of Rohit
> Yadav
> Sent: Thursday, January 31, 2013 2:13 PM
> To: Nitin Mehta
> Cc: cloudstack; Bharat Kumar; Rohit Yadav
> Subject: Re: Review Request: when a template is deleted and then copied over
> again , it is still marked as "Removed" in template_zone_ref table.
>
>
>
> > On Jan. 13, 2013, 5:15 p.m., bharat kumar wrote:
> > > Ship It!
> >
> > Rohit Yadav wrote:
> > Bharat, your reviewers should ship it and when they do that they should
> commit your patch.
>
> Nitin you gave it a ship it, can you verify the patch in current context and it's
> shippable give it a ship it, I can help commit it.
>
>
> - Rohit
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7018/#review15304
> -----------------------------------------------------------
>
>
> On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/7018/
> > -----------------------------------------------------------
> >
> > (Updated Jan. 13, 2013, 5:14 p.m.)
> >
> >
> > Review request for cloudstack and Nitin Mehta.
> >
> >
> > Description
> > -------
> >
> > This bug fix (CLOUDSTACK-970) deals with the database aspects of template
> creation, this changes the way in which the entries are added and removed
> from template_zone_ref and template_host_ref.
> >
> >
> >
> >
> > Diffs
> > -----
> >
> > server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> > server/src/com/cloud/template/HyervisorTemplateAdapter.java bdb89f6
> > server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
> >
> > Diff: https://reviews.apache.org/r/7018/diff/
> >
> >
> > Testing
> > -------
> >
> > I have tested this on the asf branch.
> >
> >
> > Thanks,
> >
> > bharat kumar
> >
> >
RE: Review Request: when a template is deleted and then copied over
again , it is still marked as "Removed" in template_zone_ref table.
Posted by Animesh Chaturvedi <an...@citrix.com>.
Nitin this has been pending on you for a long time. Please help close the review
> -----Original Message-----
> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> Sent: Friday, February 15, 2013 9:57 AM
> To: cloudstack-dev@incubator.apache.org; Rohit Yadav; Nitin Mehta
> Cc: Bharat Kumar; Abhinandan Prateek
> Subject: RE: Review Request: when a template is deleted and then copied
> over again , it is still marked as "Removed" in template_zone_ref table.
>
> Nitin
>
> Any updates? Please commit the patch if satisfied.
>
> Animesh
>
> > -----Original Message-----
> > From: Rohit Yadav [mailto:noreply@reviews.apache.org] On Behalf Of
> > Rohit Yadav
> > Sent: Thursday, January 31, 2013 2:13 PM
> > To: Nitin Mehta
> > Cc: cloudstack; Bharat Kumar; Rohit Yadav
> > Subject: Re: Review Request: when a template is deleted and then
> > copied over again , it is still marked as "Removed" in template_zone_ref
> table.
> >
> >
> >
> > > On Jan. 13, 2013, 5:15 p.m., bharat kumar wrote:
> > > > Ship It!
> > >
> > > Rohit Yadav wrote:
> > > Bharat, your reviewers should ship it and when they do that they
> > > should
> > commit your patch.
> >
> > Nitin you gave it a ship it, can you verify the patch in current
> > context and it's shippable give it a ship it, I can help commit it.
> >
> >
> > - Rohit
> >
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/7018/#review15304
> > -----------------------------------------------------------
> >
> >
> > On Jan. 13, 2013, 5:14 p.m., bharat kumar wrote:
> > >
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > https://reviews.apache.org/r/7018/
> > > -----------------------------------------------------------
> > >
> > > (Updated Jan. 13, 2013, 5:14 p.m.)
> > >
> > >
> > > Review request for cloudstack and Nitin Mehta.
> > >
> > >
> > > Description
> > > -------
> > >
> > > This bug fix (CLOUDSTACK-970) deals with the database aspects of
> > > template
> > creation, this changes the way in which the entries are added and
> > removed from template_zone_ref and template_host_ref.
> > >
> > >
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 2a0dfc8
> > > server/src/com/cloud/template/HyervisorTemplateAdapter.java
> bdb89f6
> > > server/src/com/cloud/template/TemplateManagerImpl.java 1e87de2
> > >
> > > Diff: https://reviews.apache.org/r/7018/diff/
> > >
> > >
> > > Testing
> > > -------
> > >
> > > I have tested this on the asf branch.
> > >
> > >
> > > Thanks,
> > >
> > > bharat kumar
> > >
> > >