[GitHub] [airflow] ashb edited a comment on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module

[GitBox <gi...@apache.org>]

ashb edited a comment on issue #6938: [AIRFLOW-6382] Extract provide/create session to session module
URL: https://github.com/apache/airflow/pull/6938#issuecomment-591081255
 
 
   Why did we make this change?
   
   Neither the PR nor the linked Jira give _any_ justification for the change. It doesn't reduce any imports, and personally, I found the previous name _clearer_.
   
   Now seeing that code for the first time my question would be "what is it session?"
   
   Edit, sorry, not used to old PR template.
   
   > Extracting provide_session and create_session to separate module
   > reduces number of cyclic imports and make a disctinction between
   > session and database.
   
   Can you explain to be what the difference between DB and session is? Cos I wouldn't be able to tell you if you asked me. The session _is for the db_.
   
   And how did this reduce cyclic imports when utils.db imports the new file still?!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services