You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/19 03:36:18 UTC
[GitHub] [spark] woyumen4597 opened a new pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
woyumen4597 opened a new pull request #31891:
URL: https://github.com/apache/spark/pull/31891
### What changes were proposed in this pull request?
Use fine-grained lock in SessionCatalog.tableExists, in order to lock currentDB variable rather than lock `tableExists` method which will block inner external catalog's behaviour.
### Why are the changes needed?
We have modified the underlying hive meta store which a different hive > database is placed in its own shard for performance. However, we found that the synchronized lock limits the concurrency,
### How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] baibaichen commented on pull request #31891: [SPARK-34800][SQL] Use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
baibaichen commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-803842900
@cloud-fan would you please review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802531710
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802583075
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40819/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802531710
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802573590
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31891: [SPARK-34800][SQL] Use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-803891972
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802583898
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] woyumen4597 commented on pull request #31891: [SPARK-34800][SQL] Use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
woyumen4597 commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802602785
> please fix the format of the PR title, like `[SPARK-34800][SQL] U...`
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802583075
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40819/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802583898
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136237/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31891: [SPARK-34800][SQL] Use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31891:
URL: https://github.com/apache/spark/pull/31891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #31891: SPARK-34800 use fine-grained lock in SessionCatalog.tableExists
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #31891:
URL: https://github.com/apache/spark/pull/31891#issuecomment-802574469
please fix the format of the PR title, like `[SPARK-34800][SQL] U...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org