You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/16 00:09:37 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #10246: Add support for deduplication testing

merlimat commented on a change in pull request #10246:
URL: https://github.com/apache/pulsar/pull/10246#discussion_r614472569



##########
File path: pulsar-testclient/pom.xml
##########
@@ -94,6 +94,13 @@
 			<groupId>org.hdrhistogram</groupId>
 			<artifactId>HdrHistogram</artifactId>
 		</dependency>
+		<dependency>
+			<groupId>org.json</groupId>
+			<artifactId>json</artifactId>
+			<version>20201115</version>
+			<scope>test</scope>
+		</dependency>

Review comment:
       The license of this library is `The Software shall be used for Good, not Evil.` and it's not really compatible with Apache license. We generally use Jackson and it's already in class path.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org