[jira] [Commented] (YARN-4349) Support CallerContext in YARN

["Mingliang Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-4349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001472#comment-15001472 ] 

Mingliang Liu commented on YARN-4349:
-------------------------------------

Thanks for working on this, [~leftnoteasy].

Minor comment:
{code}
+      CallerContext context =
+          new CallerContext(new CallerContext.Builder(pbContext.getContext())
+              .setSignature(pbContext.getSignature().toByteArray()));
{code}
I think this code can be simplified as:
{code}
+      CallerContext context =
+          new CallerContext.Builder(pbContext.getContext())
+              .setSignature(pbContext.getSignature().toByteArray()).build();
{code}

Is it a good idea to make the constructor {{CallerContext#CallerContext(Builder)}} private?

> Support CallerContext in YARN
> -----------------------------
>
>                 Key: YARN-4349
>                 URL: https://issues.apache.org/jira/browse/YARN-4349
>             Project: Hadoop YARN
>          Issue Type: New Feature
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>         Attachments: YARN-4349.1.patch
>
>
> More details about CallerContext please refer to description of HDFS-9184.
> From YARN's perspective, we should make following changes:
> - RMAuditLogger logs application's caller context when application submit by user
> - Add caller context to application's data in ATS along with application creation event
> From MR's perspective:
> - Set AppMaster container's context to YARN's application Id
> - Set Mapper/Reducer containers' context to task attempt id
> Protocol and RPC changes are done in HDFS-9184.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)