You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "CcLarryKomenda (via GitHub)" <gi...@apache.org> on 2023/08/07 12:16:45 UTC

[GitHub] [airflow] CcLarryKomenda commented on a diff in pull request #32921: Fix lost runs in `CronTriggerTimetable`

CcLarryKomenda commented on code in PR #32921:
URL: https://github.com/apache/airflow/pull/32921#discussion_r1285785070


##########
airflow/timetables/trigger.py:
##########
@@ -89,7 +89,7 @@ def next_dagrun_info(
             else:
                 next_start_time = self._align_to_next(restriction.earliest)
         else:
-            start_time_candidates = [self._align_to_next(DateTime.utcnow())]
+            start_time_candidates = [self._align_to_next(DateTime.utcnow().replace(second=0, microsecond=0))]

Review Comment:
   I believe he means the change shown in these 2 comments. Apologies for interjecting, but I am excited for this fix so wanted to help keep things moving.
   
   https://github.com/apache/airflow/issues/27399#issuecomment-1638152940
   https://github.com/apache/airflow/issues/27399#issuecomment-1638156248



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org