You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "htynkn (GitHub)" <gi...@apache.org> on 2018/11/06 13:28:57 UTC
[GitHub] [incubator-dubbo] htynkn opened pull request #2745:
[Dubbo-1566] add checkstyle rule to check import order
## What is the purpose of the change
Add checkstyle rule to check import order
## Brief changelog
According to `dubbo_codestyle_for_idea.xml`, `org.apache.dubbo` should be the first import and spereate with other imports with blank line.
Add a checkstyle rule to check this in CI and also fix all files which doesn't meet the requirement.
## Verifying this change
CI pass
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [x] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2745 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2745:
[Dubbo-1566] add checkstyle rule to check import order
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2745?src=pr&el=h1) Report
> Merging [#2745](https://codecov.io/gh/apache/incubator-dubbo/pull/2745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/56b219316205a12b4ce95a82b10b527798df9e34?src=pr&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2745?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2745 +/- ##
==========================================
+ Coverage 63.46% 63.52% +0.06%
==========================================
Files 577 577
Lines 25923 25923
Branches 4541 4541
==========================================
+ Hits 16451 16468 +17
+ Misses 7310 7296 -14
+ Partials 2162 2159 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2745?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `57.83% <ø> (ø)` | :arrow_up: |
| [...ubbo/config/spring/status/SpringStatusChecker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvc3RhdHVzL1NwcmluZ1N0YXR1c0NoZWNrZXIuamF2YQ==) | `75.67% <ø> (ø)` | :arrow_up: |
| [...c/main/java/org/apache/dubbo/qos/textui/TTree.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UVHJlZS5qYXZh) | `67.53% <ø> (ø)` | :arrow_up: |
| [.../main/java/org/apache/dubbo/qos/server/Server.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3NlcnZlci9TZXJ2ZXIuamF2YQ==) | `72.09% <ø> (ø)` | :arrow_up: |
| [.../spring/schema/AnnotationBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvc2NoZW1hL0Fubm90YXRpb25CZWFuRGVmaW5pdGlvblBhcnNlci5qYXZh) | `90.9% <ø> (ø)` | :arrow_up: |
| [.../main/java/org/apache/dubbo/qos/textui/TTable.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3RleHR1aS9UVGFibGUuamF2YQ==) | `83.88% <ø> (ø)` | :arrow_up: |
| [...ontext/annotation/DubboConfigBindingRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29uZmlnQmluZGluZ1JlZ2lzdHJhci5qYXZh) | `92.72% <ø> (ø)` | :arrow_up: |
| [...on/serialize/protostuff/ProtostuffObjectInput.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLXByb3Rvc3R1ZmYvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvcHJvdG9zdHVmZi9Qcm90b3N0dWZmT2JqZWN0SW5wdXQuamF2YQ==) | `95% <ø> (ø)` | :arrow_up: |
| [...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9Mb2dUZWxuZXRIYW5kbGVyLmphdmE=) | `71.42% <ø> (ø)` | :arrow_up: |
| [...ontext/annotation/DubboComponentScanRegistrar.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9hbm5vdGF0aW9uL0R1YmJvQ29tcG9uZW50U2NhblJlZ2lzdHJhci5qYXZh) | `92% <ø> (ø)` | :arrow_up: |
| ... and [73 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2745/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2745?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2745?src=pr&el=footer). Last update [56b2193...a38cd31](https://codecov.io/gh/apache/incubator-dubbo/pull/2745?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2745 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #2745:
[Dubbo-1566] add checkstyle rule to check import order
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
does import order matters? How developers know the order without running checkstyle. I am wondering if this restriction harm the productivity.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2745 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #2745:
[Dubbo-1566] add checkstyle rule to check import order
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2745 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org