You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/14 00:54:47 UTC

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7893: [7338] Allow Reloading Segments with Multiple Threads

siddharthteotia commented on a change in pull request #7893:
URL: https://github.com/apache/pinot/pull/7893#discussion_r768235313



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/messages/SegmentReloadMessage.java
##########
@@ -49,6 +50,13 @@ public SegmentReloadMessage(@Nonnull String tableNameWithType, @Nullable String
     znRecord.setBooleanField(FORCE_DOWNLOAD_KEY, forceDownload);
   }
 
+  public SegmentReloadMessage(@Nonnull String tableNameWithType, @Nullable String segmentName, boolean forceDownload,
+      int parallelism) {

Review comment:
       I know this is draft PR
   
   Just curious on the approach. How does the user specify parallelism parameter ? Can we use semaphore like we do in refresh (which is also delivered to server via helix message) ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org