You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/06 10:27:09 UTC

[GitHub] [netbeans] sdedic commented on pull request #2641: LSP support for ProgressHandles

sdedic commented on pull request #2641:
URL: https://github.com/apache/netbeans/pull/2641#issuecomment-755217635


   Possibly ready to review. Licenses and formatting will be corrected in next commit. 
   
   Please focus on NB API changes - I moved some functionality from `org.netbeans.api.progress.nb` to `org.netbeans.api.progress`: the reason is that some features that are of interest of LSP clients use default action that "only" uses some cookies or API, and is not strictly visual. There's a chance that such action can be (in the future) reflected back to the LSP protocol and client. Short term, this allowed to capture progress from Maven, Gradle and others.
   
   Short overview:
   - Default (view) action support APIs moved to `org.netbeans.api.progress`
   - The message wrapper in LSP `Server` interprets `workDoneProgressToken` in request messages, so potential ProgressHandles connect back to a token that is issued by the LSP client
   - The wrapper handles centrally `workDoneCancel` message by cancelling ProgressHandle on behalf of the client.
   - `OperationContext` is present in the default lookup (and is propagated through spawned `RequestProcessor.Task`s), ProgressHandle creation works with that to connect back to the client and issue tokens.
   - LSP `InternalHandle` implementation sends notification on start, progress and finish events
   
   I adapted certain NB usages of Progress API to use just the basic API, and removed dependencies on Swing-specific implementation, when possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists