[GitHub] [sling-org-apache-sling-servlets-resolver] joerghoh commented on a diff in pull request #29: SLING-11373: wrap resources returned from decorator to have them appe…

[GitBox <gi...@apache.org>]

joerghoh commented on code in PR #29:
URL: https://github.com/apache/sling-org-apache-sling-servlets-resolver/pull/29#discussion_r899919412


##########
src/main/java/org/apache/sling/servlets/resolver/internal/ScriptResourceResolver.java:
##########
@@ -173,14 +326,84 @@ public ScriptResourceResolver clone(Map<String, Object> o) throws LoginException
         return ScriptResourceResolver.wrap(resolver.clone(o), providerSupplier);
     }
 
-    private class ScriptResourceResolverResourceWrapper extends ResourceWrapper {
+    private class ScriptResourceResolverResourceWrapper implements Resource {
+        private final Resource delegate;
         public ScriptResourceResolverResourceWrapper(Resource resource) {
-            super(resource);
+            this.delegate = resource;
+        }
+
+        Resource getDelegate() {
+            return delegate;
         }
 
         @Override
         public ResourceResolver getResourceResolver() {
             return ScriptResourceResolver.this;
         }
+
+        @Override
+        public Resource getChild( final String relPath) {
+            return ScriptResourceResolver.this.getResource(this, relPath);

Review Comment:
   This feels wrong. Shouldn't ```getChild```  be invoked here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org