You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Brian Minchau (JIRA)" <xa...@xml.apache.org> on 2005/06/01 20:53:54 UTC
[jira] Created: (XALANJ-2133) XSLTC identity transform doesn't set all JAXP output properties
XSLTC identity transform doesn't set all JAXP output properties
---------------------------------------------------------------
Key: XALANJ-2133
URL: http://issues.apache.org/jira/browse/XALANJ-2133
Project: XalanJ2
Type: Bug
Reporter: Brian Minchau
Attachments: patch.jira.2133.txt
When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
Unfortunately the method
transferOutputProperties(SerializationHandler)
in the class:
org.apache.xalan.xsltc.trax.TransformerImpl
parses the output properties itself, and only passes those that it recognizes
to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
setOutputFormat(java.util.Properties)
and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2133) XSLTC identity transform doesn't set all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=all ]
Brian Minchau updated XALANJ-2133:
----------------------------------
Xalan info: [PatchAvailable]
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Type: Bug
> Reporter: Brian Minchau
> Attachments: patch.jira.2133.txt
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Reopened: (XALANJ-2133) XSLTC identity transform doesn't set
all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=all ]
Brian Minchau reopened XALANJ-2133:
-----------------------------------
Assignee: (was: Brian Minchau)
The patch in this issue that was previously reviewed by Morris Kwan and applied by myself has caused regressions and so was pulled out of both the main trunk and the tag xalan-j_2_7_1.
This issue is now open once again.
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Issue Type: Bug
> Affects Versions: 2.6
> Reporter: Brian Minchau
> Fix For: 2.7.1
>
> Attachments: patch.jira.2133.txt
>
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2133) XSLTC identity transform doesn't
set all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=comments#action_12373124 ]
Brian Minchau commented on XALANJ-2133:
---------------------------------------
Comments from JIRA bug Triage on Febrary 7, 2006:
> Morris already reviewed path
> Brian needs to commit.
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Type: Bug
> Versions: 2.6
> Reporter: Brian Minchau
> Assignee: Brian Minchau
> Attachments: patch.jira.2133.txt
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANJ-2133) XSLTC identity transform doesn't set all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=all ]
Brian Minchau reassigned XALANJ-2133:
-------------------------------------
Assign To: Brian Minchau
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Type: Bug
> Reporter: Brian Minchau
> Assignee: Brian Minchau
> Attachments: patch.jira.2133.txt
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2133) XSLTC identity transform doesn't set all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=all ]
Brian Minchau updated XALANJ-2133:
----------------------------------
Attachment: patch.jira.2133.txt
Attaching patch.
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Type: Bug
> Reporter: Brian Minchau
> Attachments: patch.jira.2133.txt
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANJ-2133) XSLTC identity transform doesn't set
all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=all ]
Brian Minchau resolved XALANJ-2133.
-----------------------------------
Fix Version/s: Latest Development Code
Resolution: Fixed
I just committed the patch to the latest development code.
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Issue Type: Bug
> Affects Versions: 2.6
> Reporter: Brian Minchau
> Assigned To: Brian Minchau
> Fix For: Latest Development Code
>
> Attachments: patch.jira.2133.txt
>
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2133) XSLTC identity transform doesn't set all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=comments#action_66909 ]
Brian Minchau commented on XALANJ-2133:
---------------------------------------
The patch is rather simple. Rather than parse the java.util.Properties object, as created from JAXP, and pass only the attributes that it recognizes, the body of that method simply calls the already existing
serializer.setOutputFormat(props) method and lets the serializer worry about it.
Not only is this easier, but it handles serialization extension elements on the xsl:output attribute, both now and into the future with no code changes. It is more robust. It also gets the cdata-section-elements with values of the form "b1 {uri2}b2 " working right away, as the serializer is expecting that format for the value (XSLTC was not expecting that format).
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Type: Bug
> Reporter: Brian Minchau
> Attachments: patch.jira.2133.txt
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2133) XSLTC identity transform doesn't set all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=all ]
Brian Minchau updated XALANJ-2133:
----------------------------------
reviewer: mkwan@ca.ibm.com
Reviewer set to Morris K.
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Type: Bug
> Reporter: Brian Minchau
> Attachments: patch.jira.2133.txt
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2133) XSLTC identity transform doesn't set all JAXP output properties
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=comments#action_66763 ]
Brian Minchau commented on XALANJ-2133:
---------------------------------------
A testcase to show that the Xalan specific indent-amount property
doesn't make it to the serializer, and that cdata-section-elements that have a URI in curly braces have problems too.
(One can easily switch the code below to Xalan-J interpretive to see
the difference)
static void case1() throws TransformerException, IOException {
final javax.xml.transform.TransformerFactory tFactory;
tFactory = new org.apache.xalan.xsltc.trax.TransformerFactoryImpl();
//tFactory = new org.apache.xalan.processor.TransformerFactoryImpl();
final javax.xml.transform.Transformer transformer;
transformer = tFactory.newTransformer();
transformer.setOutputProperty("method","xml");
transformer.setOutputProperty("indent","yes");
transformer.setOutputProperty("{http://xml.apache.org/xalan}indent-amount","4");
transformer.setOutputProperty("cdata-section-elements","{uri1}b1");
String val = transformer.getOutputProperty("cdata-section-elements");
transformer.setOutputProperty("cdata-section-elements",val +' '+ "b2");
StringWriter sw = new StringWriter();
StringReader sr = new StringReader(
"<?xml version='1.0' ?>\n" +
"<doc xmlns:prfx1='uri1'>\n" +
"<a><prfx1:b1>some text in b1</prfx1:b1></a>\n" +
"<b2>some text in b2</b2>\n" +
"</doc>\n");
StreamResult strmrslt = new StreamResult(sw);
StreamSource strmsrc = new StreamSource(sr);
transformer.transform(strmsrc, strmrslt);
sw.flush();
String out = sw.toString();
sw.close();
System.out.println("=================================");
System.out.println(out);
System.out.println("=================================");
}
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Type: Bug
> Reporter: Brian Minchau
> Attachments: patch.jira.2133.txt
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2133) XSLTC identity transform doesn't set all JAXP output properties
Posted by "Morris Kwan (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2133?page=comments#action_12312896 ]
Morris Kwan commented on XALANJ-2133:
-------------------------------------
I have reviewed the patch. I did not find any problem in it.
> XSLTC identity transform doesn't set all JAXP output properties
> ---------------------------------------------------------------
>
> Key: XALANJ-2133
> URL: http://issues.apache.org/jira/browse/XALANJ-2133
> Project: XalanJ2
> Type: Bug
> Reporter: Brian Minchau
> Assignee: Brian Minchau
> Attachments: patch.jira.2133.txt
>
> When running the XSLTC identity transform via JAXP it is possible to effectively set xsl:output properties via the JAXP setOutputProperty() method.
> Unfortunately the method
> transferOutputProperties(SerializationHandler)
> in the class:
> org.apache.xalan.xsltc.trax.TransformerImpl
> parses the output properties itself, and only passes those that it recognizes
> to the handler. In doing so it fails to pass any xalan extension properties, such as "{http://xml.apache.org/xalan}indent-amount". It also does its own parsing of "cdata-section-elements" and incorrectly parses the URI. It doesn't look for a URI surrounded by braces, as it should according to JAXP.
> All this method does is parse the properties and call setter-s one at a time on the handler. The fix is simply to pass the java.util.Properties object to the already public API that is on the Serializer interface, namely
> setOutputFormat(java.util.Properties)
> and let it deal with all of the properties itself. This will smoothly get all properties set via JAXP to the serializer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org