[GitHub] [tvm] areusch commented on a change in pull request #8345: [Graph Debug Executor] Add exception for profile with remote devices

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #8345:
URL: https://github.com/apache/tvm/pull/8345#discussion_r659994309



##########
File path: python/tvm/contrib/debugger/debug_executor.py
##########
@@ -105,6 +106,7 @@ def __init__(self, module, device, graph_json_str, dump_root):
         self._profile = module["profile"]
         graph_executor.GraphModule.__init__(self, module)
         self._create_debug_env(graph_json_str, device)
+        self._device = device[0]

Review comment:
       i'm worried that the cpu device might not be first in the list. maybe we should just store a local flag e.g. `self._has_remote_device = any(d.device_type >= base.RPC_SESS_MASK for d in device)`
   
   and use that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org