You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Ben Reser <be...@reser.org> on 2012/11/21 21:07:11 UTC

APR 1.3.x branch doesn't build properly with libtool 2.4

This came up recently on the svn-dev list.

http://mail-archives.apache.org/mod_mbox/subversion-dev/201211.mbox/browser

It doesn't build because libtool.m4 that comes with libtool 2.4 uses:
LIBTOOL='$(SHELL) $(top_builddir)/libtool'

And APR doesn't define top_builddir.

In 1.4 and newer versions of APR this has been resolved by running a
sed command against build/libtool.m4 to replace top_builddir with
apr_builddir.

Specifically, this was done in r1125475 on apr-trunk.

Based on this google search quite a few people seem to have run into this:
https://www.google.com/search?q=apr+1.3+LIBTOOL+top_builddir

I realize that APR 1.3.x is probably not something you care about
terribly much since development has moved along.  However, Subversion
still has places where we recommend that in our instructions (e.g.
Subversion 1.7.x), which I'm going to get corrected, but obviously
can't correct the existing older versions in the wild.

In the interest of users though I think it might be nice to patch the
1.3.x branch so that it either builds with libtool 2.4 (e.g. adopting
the fix newer versions of APR have) or make buildconf refuse to work
with newer libtools.

Given that the fix is already available, I'd recommend simply applying the fix.

Re: APR 1.3.x branch doesn't build properly with libtool 2.4

Posted by Ben Reser <be...@reser.org>.
Didn't really expect a release.  The documentation that's referencing
1.3 was actually suggesting that people checkout from your 1.3.x
branch.  So your fixes should resolve the issue for those people.

Thanks.

On Wed, Nov 21, 2012 at 2:26 PM, Rainer Jung <ra...@kippdata.de> wrote:
> On 21.11.2012 21:07, Ben Reser wrote:
>> This came up recently on the svn-dev list.
>>
>> http://mail-archives.apache.org/mod_mbox/subversion-dev/201211.mbox/browser
>>
>> It doesn't build because libtool.m4 that comes with libtool 2.4 uses:
>> LIBTOOL='$(SHELL) $(top_builddir)/libtool'
>>
>> And APR doesn't define top_builddir.
>>
>> In 1.4 and newer versions of APR this has been resolved by running a
>> sed command against build/libtool.m4 to replace top_builddir with
>> apr_builddir.
>>
>> Specifically, this was done in r1125475 on apr-trunk.
>>
>> Based on this google search quite a few people seem to have run into this:
>> https://www.google.com/search?q=apr+1.3+LIBTOOL+top_builddir
>>
>> I realize that APR 1.3.x is probably not something you care about
>> terribly much since development has moved along.  However, Subversion
>> still has places where we recommend that in our instructions (e.g.
>> Subversion 1.7.x), which I'm going to get corrected, but obviously
>> can't correct the existing older versions in the wild.
>>
>> In the interest of users though I think it might be nice to patch the
>> 1.3.x branch so that it either builds with libtool 2.4 (e.g. adopting
>> the fix newer versions of APR have) or make buildconf refuse to work
>> with newer libtools.
>
> I backported a few build fixes to 1.3.x. I'm not very confident though
> that there will be enough momentum for a release, but at least there are
> 1.3 svn revisions now, that you can refer people to:
>
> r1412309: buildconf fixes including the one above
> r1412318: apr_common.m4 fixes
> r1412321: Updates for config.guess and config.sub
> r1412330: Makefile.in fixes
>
> Regards,
>
> Rainer

Re: APR 1.3.x branch doesn't build properly with libtool 2.4

Posted by Rainer Jung <ra...@kippdata.de>.
On 21.11.2012 21:07, Ben Reser wrote:
> This came up recently on the svn-dev list.
> 
> http://mail-archives.apache.org/mod_mbox/subversion-dev/201211.mbox/browser
> 
> It doesn't build because libtool.m4 that comes with libtool 2.4 uses:
> LIBTOOL='$(SHELL) $(top_builddir)/libtool'
> 
> And APR doesn't define top_builddir.
> 
> In 1.4 and newer versions of APR this has been resolved by running a
> sed command against build/libtool.m4 to replace top_builddir with
> apr_builddir.
> 
> Specifically, this was done in r1125475 on apr-trunk.
> 
> Based on this google search quite a few people seem to have run into this:
> https://www.google.com/search?q=apr+1.3+LIBTOOL+top_builddir
> 
> I realize that APR 1.3.x is probably not something you care about
> terribly much since development has moved along.  However, Subversion
> still has places where we recommend that in our instructions (e.g.
> Subversion 1.7.x), which I'm going to get corrected, but obviously
> can't correct the existing older versions in the wild.
> 
> In the interest of users though I think it might be nice to patch the
> 1.3.x branch so that it either builds with libtool 2.4 (e.g. adopting
> the fix newer versions of APR have) or make buildconf refuse to work
> with newer libtools.

I backported a few build fixes to 1.3.x. I'm not very confident though
that there will be enough momentum for a release, but at least there are
1.3 svn revisions now, that you can refer people to:

r1412309: buildconf fixes including the one above
r1412318: apr_common.m4 fixes
r1412321: Updates for config.guess and config.sub
r1412330: Makefile.in fixes

Regards,

Rainer

Re: APR 1.3.x branch doesn't build properly with libtool 2.4

Posted by Ben Reser <be...@reser.org>.
Apologies that first link should have been:
http://mail-archives.apache.org/mod_mbox/subversion-dev/201211.mbox/%3C20121121065024.GA3841%40thyrsus.com%3E

On Wed, Nov 21, 2012 at 12:07 PM, Ben Reser <be...@reser.org> wrote:
> This came up recently on the svn-dev list.
>
> http://mail-archives.apache.org/mod_mbox/subversion-dev/201211.mbox/browser
>
> It doesn't build because libtool.m4 that comes with libtool 2.4 uses:
> LIBTOOL='$(SHELL) $(top_builddir)/libtool'
>
> And APR doesn't define top_builddir.
>
> In 1.4 and newer versions of APR this has been resolved by running a
> sed command against build/libtool.m4 to replace top_builddir with
> apr_builddir.
>
> Specifically, this was done in r1125475 on apr-trunk.
>
> Based on this google search quite a few people seem to have run into this:
> https://www.google.com/search?q=apr+1.3+LIBTOOL+top_builddir
>
> I realize that APR 1.3.x is probably not something you care about
> terribly much since development has moved along.  However, Subversion
> still has places where we recommend that in our instructions (e.g.
> Subversion 1.7.x), which I'm going to get corrected, but obviously
> can't correct the existing older versions in the wild.
>
> In the interest of users though I think it might be nice to patch the
> 1.3.x branch so that it either builds with libtool 2.4 (e.g. adopting
> the fix newer versions of APR have) or make buildconf refuse to work
> with newer libtools.
>
> Given that the fix is already available, I'd recommend simply applying the fix.