[jira] [Closed] (TAP5-1002) action link passed through URLRewriterRule lost page context

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TAP5-1002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-1002.
--------------------------------------

    Resolution: Won't Fix
      Assignee: Howard M. Lewis Ship

This bug is probably accurate, but URLRewriteRule has been deprecated in 5.2 and removed in 5.3.

> action link passed through URLRewriterRule lost page context
> ------------------------------------------------------------
>
>                 Key: TAP5-1002
>                 URL: https://issues.apache.org/jira/browse/TAP5-1002
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Jan Jirout
>            Assignee: Howard M. Lewis Ship
>         Attachments: fix.zip
>
>
> When application create action link and during generating form action ink and URLRewriterRule rewriting is applied then page context is lost.
> It seems that LinkImpl is correctly created in ComponentEventLinkEncoderImpl at 194 with forForm=true. Next is ComponentEventLinkEncoderMethodAdvice#advice called. There is created "fakeRequest". This "fakeRequest" is then passed through all registered URLRewriterRule implementations and rewrited request is returned. If "fakeRequest" and rewritten request are not same then LinkImpl is rewritten. This is the place where is the problem, LinkImpl rewriting code is:
>            newLink = new LinkImpl(newUrl, false, false, response, null);
> so the rewritten link have always forForm=false. And this is the problem. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira