You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/18 20:50:47 UTC

[GitHub] [airflow] xinbinhuang commented on a change in pull request #13156: Add timeout option to gcs hook methods.

xinbinhuang commented on a change in pull request #13156:
URL: https://github.com/apache/airflow/pull/13156#discussion_r546084232



##########
File path: tests/providers/google/cloud/hooks/test_gcs.py
##########
@@ -672,7 +672,7 @@ def test_download_to_file(self, mock_service):
         )
 
         self.assertEqual(response, test_file)
-        download_filename_method.assert_called_once_with(test_file)
+        download_filename_method.assert_called_once_with(test_file, timeout=60)

Review comment:
       How about swapping the `timeout=60` with a variable as well? So that we don't need to hard code them in all test cases




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org