You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2012/12/12 13:23:21 UTC

[jira] [Commented] (BOOKKEEPER-404) Deprecate non-SubscriptionOptions Subscriber Apis

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529909#comment-13529909 ] 

Hadoop QA commented on BOOKKEEPER-404:
--------------------------------------

Testing JIRA BOOKKEEPER-404


Patch [0001-BOOKKEEPER-404-Deprecate-non-SubscriptionOptions-Sub.patch|https://issues.apache.org/jira/secure/attachment/12560547/0001-BOOKKEEPER-404-Deprecate-non-SubscriptionOptions-Sub.patch] downloaded at Wed Dec 12 11:53:01 UTC 2012

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 120
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 FINDBUGS{color}
.    {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings
{color:red}-1 TESTS{color}
.    Tests run: 527
.    Tests failed: 1
.    Tests errors: 0

.    The patch failed the following testcases:

.      testServerSideThrottle[1](org.apache.hedwig.server.delivery.TestThrottlingDelivery)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/bookkeeper-trunk-precommit-build/105/
                
> Deprecate non-SubscriptionOptions Subscriber Apis
> -------------------------------------------------
>
>                 Key: BOOKKEEPER-404
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-404
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: hedwig-client
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: 0001-BOOKKEEPER-404-Deprecate-non-SubscriptionOptions-Sub.patch
>
>
> Add deprecation annotation. Add more doc for the SubscriptionOptions versions. Add util methods, to easily create SubscriptionOptions, so that usage is no harder than using the non-SubscriptionOptions versions

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira