You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/08/09 08:10:32 UTC
Review Request 50918: LENS-1270 : AlarmService to be inited through
configuration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50918/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1270
https://issues.apache.org/jira/browse/LENS-1270
Repository: lens
Description
-------
AlarmService to be inited through configuration
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/LensServices.java a709f16
lens-server/src/main/resources/lensserver-default.xml d672c88
lens-server/src/test/resources/lens-site.xml 908fbb2
src/site/apt/admin/config.apt 4291798
Diff: https://reviews.apache.org/r/50918/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 50918: LENS-1270 : AlarmService to be inited
through configuration
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50918/#review145182
-----------------------------------------------------------
Fix it, then Ship it!
lens-server/src/test/resources/lens-site.xml (line 95)
<https://reviews.apache.org/r/50918/#comment211342>
Can we remove "service" from the name? None of the others have "service" in the name.
- Rajat Khandelwal
On Aug. 9, 2016, 1:40 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50918/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 1:40 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1270
> https://issues.apache.org/jira/browse/LENS-1270
>
>
> Repository: lens
>
>
> Description
> -------
>
> AlarmService to be inited through configuration
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LensServices.java a709f16
> lens-server/src/main/resources/lensserver-default.xml d672c88
> lens-server/src/test/resources/lens-site.xml 908fbb2
> src/site/apt/admin/config.apt 4291798
>
> Diff: https://reviews.apache.org/r/50918/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 50918: LENS-1270 : AlarmService to be inited
through configuration
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50918/#review145183
-----------------------------------------------------------
Ship it!
Ship It!
- Puneet Gupta
On Aug. 9, 2016, 8:10 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50918/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2016, 8:10 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1270
> https://issues.apache.org/jira/browse/LENS-1270
>
>
> Repository: lens
>
>
> Description
> -------
>
> AlarmService to be inited through configuration
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/LensServices.java a709f16
> lens-server/src/main/resources/lensserver-default.xml d672c88
> lens-server/src/test/resources/lens-site.xml 908fbb2
> src/site/apt/admin/config.apt 4291798
>
> Diff: https://reviews.apache.org/r/50918/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 50918: LENS-1270 : AlarmService to be inited
through configuration
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50918/
-----------------------------------------------------------
(Updated Aug. 9, 2016, 12:06 p.m.)
Review request for lens.
Changes
-------
Fixed test and review comments
Bugs: LENS-1270
https://issues.apache.org/jira/browse/LENS-1270
Repository: lens
Description
-------
AlarmService to be inited through configuration
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/LensServices.java a709f16
lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 217879f
lens-server/src/main/resources/lensserver-default.xml d672c88
lens-server/src/test/resources/lens-site.xml 908fbb2
src/site/apt/admin/config.apt 4291798
Diff: https://reviews.apache.org/r/50918/diff/
Testing
-------
Thanks,
Amareshwari Sriramadasu