You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ja...@apache.org on 2020/06/03 10:15:19 UTC
[flink] 01/03: [hotfix][hbase] Rename HBase connector option
'zookeeper.znode-parent' to 'zookeeper.znode.parent'
This is an automated email from the ASF dual-hosted git repository.
jark pushed a commit to branch release-1.11
in repository https://gitbox.apache.org/repos/asf/flink.git
commit fe7734d890b318a644068474c295c361a2d79ce4
Author: Jark Wu <ja...@apache.org>
AuthorDate: Thu May 28 19:02:37 2020 +0800
[hotfix][hbase] Rename HBase connector option 'zookeeper.znode-parent' to 'zookeeper.znode.parent'
'zookeeper.znode.parent' configuration key is used in HBase, in order to be close to HBase users, it would be better to use the same key 'zookeeper.znode.parent'.
---
.../org/apache/flink/connector/hbase/HBaseDynamicTableFactory.java | 2 +-
.../java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java | 4 ++--
.../apache/flink/connector/hbase/HBaseDynamicTableFactoryTest.java | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/HBaseDynamicTableFactory.java b/flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/HBaseDynamicTableFactory.java
index 64b381f..b0e6dee 100644
--- a/flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/HBaseDynamicTableFactory.java
+++ b/flink-connectors/flink-connector-hbase/src/main/java/org/apache/flink/connector/hbase/HBaseDynamicTableFactory.java
@@ -63,7 +63,7 @@ public class HBaseDynamicTableFactory implements DynamicTableSourceFactory, Dyna
.withDescription("Required. It defines HBase Zookeeper quorum.");
private static final ConfigOption<String> ZOOKEEPER_ZNODE_PARENT = ConfigOptions
- .key("zookeeper.znode-parent")
+ .key("zookeeper.znode.parent")
.stringType()
.defaultValue("/hbase")
.withDescription("Optional. The root dir in Zookeeper for HBase cluster, default value is '/hbase'");
diff --git a/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java b/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java
index 7724873..3777dec 100644
--- a/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java
+++ b/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseConnectorITCase.java
@@ -389,7 +389,7 @@ public class HBaseConnectorITCase extends HBaseTestBase {
" 'connector' = 'hbase-1.4'," +
" 'table-name' = '" + TEST_TABLE_1 + "'," +
" 'zookeeper.quorum' = '" + getZookeeperQuorum() + "'," +
- " 'zookeeper.znode-parent' = '/hbase'" +
+ " 'zookeeper.znode.parent' = '/hbase'" +
")");
}
@@ -489,7 +489,7 @@ public class HBaseConnectorITCase extends HBaseTestBase {
" 'connector' = 'hbase-1.4',\n" +
" 'table-name' = 'testTable3',\n" +
" 'zookeeper.quorum' = '" + quorum + "',\n" +
- " 'zookeeper.znode-parent' = '/hbase' " +
+ " 'zookeeper.znode.parent' = '/hbase' " +
")";
}
tEnv.executeSql(ddl);
diff --git a/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseDynamicTableFactoryTest.java b/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseDynamicTableFactoryTest.java
index 17fe3a6..32e104a 100644
--- a/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseDynamicTableFactoryTest.java
+++ b/flink-connectors/flink-connector-hbase/src/test/java/org/apache/flink/connector/hbase/HBaseDynamicTableFactoryTest.java
@@ -224,7 +224,7 @@ public class HBaseDynamicTableFactoryTest {
options.put("connector", "hbase-1.4");
options.put("table-name", "testHBastTable");
options.put("zookeeper.quorum", "localhost:2181");
- options.put("zookeeper.znode-parent", "/flink");
+ options.put("zookeeper.znode.parent", "/flink");
options.put("sink.buffer-flush.max-size", "10mb");
options.put("sink.buffer-flush.max-rows", "1000");
options.put("sink.buffer-flush.interval", "10s");