You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/04/04 01:51:24 UTC
[jira] Created: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
LeaseChecker daemon should not be started in DFSClient constructor
------------------------------------------------------------------
Key: HADOOP-3169
URL: https://issues.apache.org/jira/browse/HADOOP-3169
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616211#action_12616211 ]
Raghu Angadi commented on HADOOP-3169:
--------------------------------------
+1 for simple locking using LeaseChecker object instead of AtomicBoolean and a synchronizedSortedMap.
Also should the LeaseChecker thread be closed when there are no leases pending for a few seconds or so? The justification is same as the one for delaying creation of the thread.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616845#action_12616845 ]
Hadoop QA commented on HADOOP-3169:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12386746/3169_20080723b.patch
against trunk revision 679601.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2949/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2949/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2949/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2949/console
This message is automatically generated.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3169:
-------------------------------------------
Status: Open (was: Patch Available)
Need to try hudson again
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch, 3169_20080725.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-3169:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this. Thanks, Nicholas!
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch, 3169_20080725.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616201#action_12616201 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3169:
------------------------------------------------
I use two locks for protecting two objects, pendingCreate and daemon. You are right that it is possible to use one lock.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3169:
-------------------------------------------
Status: Patch Available (was: Open)
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch, 3169_20080725.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3169:
-------------------------------------------
Status: Patch Available (was: Open)
Passed tests locally, try hudson.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3169:
-------------------------------------------
Attachment: 3169_20080725.patch
3169_20080725.patch: updated with trunk.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch, 3169_20080725.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615830#action_12615830 ]
Hairong Kuang commented on HADOOP-3169:
---------------------------------------
I feel that we do not need two locks, started and synchornized pendingCreates in LeaseChecker. Instead we can make put and remove synchronized.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624699#action_12624699 ]
Hudson commented on HADOOP-3169:
--------------------------------
Integrated in Hadoop-trunk #581 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/581/])
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch, 3169_20080725.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617077#action_12617077 ]
Hadoop QA commented on HADOOP-3169:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12386907/3169_20080725.patch
against trunk revision 679879.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2954/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2954/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2954/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2954/console
This message is automatically generated.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch, 3169_20080725.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616255#action_12616255 ]
Raghu Angadi commented on HADOOP-3169:
--------------------------------------
I agree this is not required. It is just an extension of what this jira already proposes to to to. An improvement over an improvement :)
> This is useful if there are many clients (with different users) and all of them keep creating and closing files.
I don't think this requires multiple clients or users. Imagine a case where a task writes one file and closes the file system. In that case, lease checker will stay as long as the task (because of FS cache) though there is one using it.
I did not mean to make it a requirement for this jira.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE reassigned HADOOP-3169:
----------------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3169:
-------------------------------------------
Attachment: 3169_20080723b.patch
3169_20080723b.patch: only use one lock.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3169:
-------------------------------------------
Attachment: 3169_20080718.patch
3169_20080718.patch: start the lease checker daemon when the first file is created, not in the DFSClient constructor.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3169:
-------------------------------------------
Attachment: 3169_20080721.patch
3169_20080721.patch: added a test and some messages.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617099#action_12617099 ]
Hairong Kuang commented on HADOOP-3169:
---------------------------------------
+1. The patch looks good.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch, 3169_20080725.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3169) LeaseChecker daemon should not be
started in DFSClient constructor
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616252#action_12616252 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3169:
------------------------------------------------
> Also should the LeaseChecker thread be closed when there are no leases pending for a few seconds or so? The justification is same as the one for delaying creation of the thread.
This is a good idea. Hairong also has suggested this before. This is useful if there are many clients (with different users) and all of them keep creating and closing files. It seems such case is not common. So we don't want to introduce complex codes to handle it.
> LeaseChecker daemon should not be started in DFSClient constructor
> ------------------------------------------------------------------
>
> Key: HADOOP-3169
> URL: https://issues.apache.org/jira/browse/HADOOP-3169
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 3169_20080718.patch, 3169_20080721.patch, 3169_20080723b.patch
>
>
> LeaseChecker daemon periodically renew leases with NameNode. However, if there is no file creation, LeaseChecker daemon should not be started for saving resources and better performance.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.