You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2017/12/29 12:28:37 UTC
groovy git commit: Trivial refactoring: use Integer.compare(int,
int) instead
Repository: groovy
Updated Branches:
refs/heads/master 033b416a0 -> 7050ae43f
Trivial refactoring: use Integer.compare(int, int) instead
Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/7050ae43
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/7050ae43
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/7050ae43
Branch: refs/heads/master
Commit: 7050ae43fd77f3bbff7ee29c12235fce192064d3
Parents: 033b416
Author: sunlan <su...@apache.org>
Authored: Fri Dec 29 20:28:20 2017 +0800
Committer: sunlan <su...@apache.org>
Committed: Fri Dec 29 20:28:33 2017 +0800
----------------------------------------------------------------------
.../org/codehaus/groovy/transform/SortableASTTransformation.java | 2 +-
.../org/codehaus/groovy/transform/ToStringASTTransformation.java | 2 +-
.../groovy/transform/TupleConstructorASTTransformation.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/groovy/blob/7050ae43/src/main/java/org/codehaus/groovy/transform/SortableASTTransformation.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/transform/SortableASTTransformation.java b/src/main/java/org/codehaus/groovy/transform/SortableASTTransformation.java
index 523cc97..0485e6d 100644
--- a/src/main/java/org/codehaus/groovy/transform/SortableASTTransformation.java
+++ b/src/main/java/org/codehaus/groovy/transform/SortableASTTransformation.java
@@ -226,7 +226,7 @@ public class SortableASTTransformation extends AbstractASTTransformation {
if (includes != null) {
Comparator<PropertyNode> includeComparator = new Comparator<PropertyNode>() {
public int compare(PropertyNode o1, PropertyNode o2) {
- return Integer.valueOf(includes.indexOf(o1.getName())).compareTo(includes.indexOf(o2.getName()));
+ return Integer.compare(includes.indexOf(o1.getName()), includes.indexOf(o2.getName()));
}
};
Collections.sort(properties, includeComparator);
http://git-wip-us.apache.org/repos/asf/groovy/blob/7050ae43/src/main/java/org/codehaus/groovy/transform/ToStringASTTransformation.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/transform/ToStringASTTransformation.java b/src/main/java/org/codehaus/groovy/transform/ToStringASTTransformation.java
index 559e8e0..36f376f 100644
--- a/src/main/java/org/codehaus/groovy/transform/ToStringASTTransformation.java
+++ b/src/main/java/org/codehaus/groovy/transform/ToStringASTTransformation.java
@@ -212,7 +212,7 @@ public class ToStringASTTransformation extends AbstractASTTransformation {
if (includes != null) {
Comparator<ToStringElement> includeComparator = new Comparator<ToStringElement>() {
public int compare(ToStringElement tse1, ToStringElement tse2) {
- return Integer.valueOf(includes.indexOf(tse1.name)).compareTo(includes.indexOf(tse2.name));
+ return Integer.compare(includes.indexOf(tse1.name), includes.indexOf(tse2.name));
}
};
Collections.sort(elements, includeComparator);
http://git-wip-us.apache.org/repos/asf/groovy/blob/7050ae43/src/main/java/org/codehaus/groovy/transform/TupleConstructorASTTransformation.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/codehaus/groovy/transform/TupleConstructorASTTransformation.java b/src/main/java/org/codehaus/groovy/transform/TupleConstructorASTTransformation.java
index a32a2ad..20577cb 100644
--- a/src/main/java/org/codehaus/groovy/transform/TupleConstructorASTTransformation.java
+++ b/src/main/java/org/codehaus/groovy/transform/TupleConstructorASTTransformation.java
@@ -236,7 +236,7 @@ public class TupleConstructorASTTransformation extends AbstractASTTransformation
if (includes != null) {
Comparator<Parameter> includeComparator = new Comparator<Parameter>() {
public int compare(Parameter p1, Parameter p2) {
- return Integer.valueOf(includes.indexOf(p1.getName())).compareTo(includes.indexOf(p2.getName()));
+ return Integer.compare(includes.indexOf(p1.getName()), includes.indexOf(p2.getName()));
}
};
Collections.sort(params, includeComparator);